Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753920AbYGVPIw (ORCPT ); Tue, 22 Jul 2008 11:08:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751426AbYGVPIn (ORCPT ); Tue, 22 Jul 2008 11:08:43 -0400 Received: from gw.goop.org ([64.81.55.164]:50670 "EHLO mail.goop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751061AbYGVPIn (ORCPT ); Tue, 22 Jul 2008 11:08:43 -0400 Message-ID: <4885F7EF.7080803@goop.org> Date: Tue, 22 Jul 2008 08:08:31 -0700 From: Jeremy Fitzhardinge User-Agent: Thunderbird 2.0.0.14 (X11/20080501) MIME-Version: 1.0 To: Johannes Weiner CC: Ingo Molnar , Linus Torvalds , linux-kernel@vger.kernel.org, Thomas Gleixner , "H. Peter Anvin" , Andrew Morton Subject: Re: [git pull] x86 fixes References: <20080722140348.GA26267@elte.hu> <87prp6j8bh.fsf@saeurebad.de> In-Reply-To: <87prp6j8bh.fsf@saeurebad.de> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1647 Lines: 54 Johannes Weiner wrote: > Hi, > > Ingo Molnar writes: > > >> Linus, >> >> Please pull the latest x86 fixes git tree from: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git x86-fixes-for-linus >> >> Thanks, >> >> Ingo >> >> ------------------> >> Jan Kratochvil (1): >> x86: fix crash due to missing debugctlmsr on AMD K6-3 >> >> Jeremy Fitzhardinge (2): >> x86: rename PTE_MASK to PTE_PFN_MASK >> x86: add PTE_FLAGS_MASK >> > > Are you serious? It goes _this_ fast? The patch came into my mbox at > 8:00am this morning and you push it to Linus at 4:00pm already? > > What about the inconsistency it introduces? When I look at PAGE_MASK > for example, it masks out the PAGE offset. PTE_MASK masks out PTE > specifca from a value. > > Now, I assume PTE_PFN_MASK masks out the PFN. Oh, wait, it masks the > protection bits. PAGE_MASK turns an address into its page address. PTE_PFN_MASK takes a pte value and returns the pte's pfn portion (which is shifted so it's actually a page address). In both cases, the X_MASK terminology means that X is extracted, not excluded. Which makes sense; if you have a packed bitfield containing multiple values, you wouldn't expect X to be the list of things *not* extracted. (I would be happy to have a PAGE_OFFSET_MASK for all the places where you want to extract the offset.) J -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/