Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753252AbYGVQjy (ORCPT ); Tue, 22 Jul 2008 12:39:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751810AbYGVQjn (ORCPT ); Tue, 22 Jul 2008 12:39:43 -0400 Received: from mtiwmhc11.worldnet.att.net ([204.127.131.115]:61893 "EHLO mtiwmhc11.worldnet.att.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751802AbYGVQjl (ORCPT ); Tue, 22 Jul 2008 12:39:41 -0400 Message-ID: <48860D4B.8070003@lwfinger.net> Date: Tue, 22 Jul 2008 11:39:39 -0500 From: Larry Finger User-Agent: Thunderbird 2.0.0.12 (X11/20071114) MIME-Version: 1.0 To: David Miller , Patrick McHardy CC: torvalds@linux-foundation.org, akpm@linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org Subject: Kernel WARNING: at net/core/dev.c:1330 __netif_schedule+0x2c/0x98() References: <4885104A.2070201@lwfinger.net> <20080721.161517.27161039.davem@davemloft.net> <48857F74.2040406@lwfinger.net> <20080722.043220.247312412.davem@davemloft.net> <4885DA49.50703@lwfinger.net> In-Reply-To: <4885DA49.50703@lwfinger.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5413 Lines: 134 David and Patrick, Here is the latest on this problem. I pulled from Linus's tree this morning and now have git-05752-g93ded9b. The kernel WARNING from __netif_schedule and the lockdep warning are present with or without the patches from yesterday. As I stated earlier, the kernel WARNING (it was a BUG then) was introduced in commit 37437bb2 when the BUG statement was entered. The lockdep warning started with the next commit (16361127). I am not using any network traffic shaping. Is it correct that the faulty condition is not that q == &noop_qdisc, but that __netif_schedule was called when that condition exists? The lockdep warning is: ============================================= [ INFO: possible recursive locking detected ] 2.6.26-Linus-git-05752-g93ded9b #49 --------------------------------------------- NetworkManager/2611 is trying to acquire lock: (&dev->addr_list_lock){-...}, at: [] dev_mc_sync+0x19/0x57 but task is already holding lock: (&dev->addr_list_lock){-...}, at: [] dev_set_rx_mode+0x19/0x2e other info that might help us debug this: 2 locks held by NetworkManager/2611: #0: (rtnl_mutex){--..}, at: [] rtnetlink_rcv+0x12/0x27 #1: (&dev->addr_list_lock){-...}, at: [] dev_set_rx_mode+0x19/0x2e stack backtrace: Pid: 2611, comm: NetworkManager Not tainted 2.6.26-Linus-git-05752-g93ded9b #49 Call Trace: [] __lock_acquire+0xb7b/0xecc [] lock_acquire+0x51/0x6a [] dev_mc_sync+0x19/0x57 [] _spin_lock_bh+0x23/0x2c [] dev_mc_sync+0x19/0x57 [] dev_set_rx_mode+0x21/0x2e [] dev_open+0x8e/0xb0 [] dev_change_flags+0xa6/0x163 [] do_setlink+0x286/0x349 [] rtnetlink_rcv_msg+0x0/0x1ec [] rtnetlink_rcv_msg+0x0/0x1ec [] rtnetlink_rcv_msg+0x0/0x1ec [] rtnl_setlink+0x10b/0x10d [] rtnetlink_rcv_msg+0x0/0x1ec [] netlink_rcv_skb+0x34/0x7d [] rtnetlink_rcv+0x21/0x27 [] netlink_unicast+0x1f0/0x261 [] __alloc_skb+0x66/0x12a [] netlink_sendmsg+0x268/0x27b [] sock_sendmsg+0xcb/0xe3 [] autoremove_wake_function+0x0/0x2e [] verify_iovec+0x46/0x82 [] sys_sendmsg+0x217/0x28a [] sockfd_lookup_light+0x1a/0x52 [] trace_hardirqs_on_caller+0xef/0x113 [] trace_hardirqs_on_thunk+0x3a/0x3f [] system_call_after_swapgs+0x7b/0x80 ======================================================== The logged data for the WARNING is as follows: ------------[ cut here ]------------ WARNING: at net/core/dev.c:1330 __netif_schedule+0x2c/0x98() Modules linked in: af_packet nfs lockd nfs_acl rfkill_input sunrpc cpufreq_conservative cpufreq_userspace cpufreq_powersave powernow_k8 fuse loop dm_mod arc4 ecb crypto_blkcipher b43 firmware_class rfkill mac80211 cfg80211 led_class input_polldev battery ac button ssb serio_raw forcedeth sr_mod cdrom k8temp hwmon sg sd_mod ehci_hcd ohci_hcd usbcore edd fan thermal processor ext3 mbcache jbd pata_amd ahci libata scsi_mod dock Pid: 1990, comm: b43 Not tainted 2.6.26-Linus-git-05752-g93ded9b #49 Call Trace: [] warn_on_slowpath+0x51/0x8c [] __netif_schedule+0x2c/0x98 [] ieee80211_scan_completed+0x26b/0x2f1 [mac80211] [] ieee80211_sta_scan_work+0x0/0x1b8 [mac80211] [] run_workqueue+0xf0/0x1f2 [] worker_thread+0xdb/0xea [] autoremove_wake_function+0x0/0x2e [] worker_thread+0x0/0xea [] kthread+0x47/0x73 [] trace_hardirqs_on_thunk+0x3a/0x3f [] child_rip+0xa/0x11 [] restore_args+0x0/0x30 [] kthreadd+0x188/0x1ad [] kthread+0x0/0x73 [] child_rip+0x0/0x11 ---[ end trace 42d234b678daea7a ]--- Other info I have found. The call to __netif_schedule from ieee80211_scan_completed is through the following code from include/linux/netdevice.h: /** * netif_wake_queue - restart transmit * @dev: network device * * Allow upper layers to call the device hard_start_xmit routine. * Used for flow control when transmit resources are available. */ static inline void netif_tx_wake_queue(struct netdev_queue *dev_queue) { #ifdef CONFIG_NETPOLL_TRAP if (netpoll_trap()) { clear_bit(__QUEUE_STATE_XOFF, &dev_queue->state); return; } #endif if (test_and_clear_bit(__QUEUE_STATE_XOFF, &dev_queue->state)) __netif_schedule(dev_queue->qdisc); } It doesn't make any difference if CONFIG_NETPOLL_TRAP is defined or not. Please let me know if I can provide any further information, Larry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/