Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755094AbYGVSAk (ORCPT ); Tue, 22 Jul 2008 14:00:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753336AbYGVSAN (ORCPT ); Tue, 22 Jul 2008 14:00:13 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:36519 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753111AbYGVSAM (ORCPT ); Tue, 22 Jul 2008 14:00:12 -0400 Date: Tue, 22 Jul 2008 18:42:37 +0100 From: Alan Cox To: WANG Cong Cc: Eric Sesterhenn , xiyou.wangcong@gmail.com, linux-kernel@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net, jdike@addtoit.com Subject: Re: [Patch] um: fix a build error Message-ID: <20080722184237.7532d052@lxorguk.ukuu.org.uk> In-Reply-To: <20080722173509.GE3081@hack.voiplan.pt> References: <20080722105812.GB5283@alice> <20080722115354.79ba2314@lxorguk.ukuu.org.uk> <20080722173509.GE3081@hack.voiplan.pt> X-Mailer: Claws Mail 3.4.0 (GTK+ 2.12.11; x86_64-redhat-linux-gnu) Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a Lloegr o'r rhif cofrestru 3798903 Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1161 Lines: 32 On Tue, 22 Jul 2008 18:35:09 +0100 WANG Cong wrote: > On Tue, Jul 22, 2008 at 11:53:54AM +0100, Alan Cox wrote: > >> Signed-off-by: Eric Sesterhenn > >> > >> --- linux-2.6/arch/um/drivers/line.c.orig 2008-07-22 12:06:17.000000000 +0200 > >> +++ linux-2.6/arch/um/drivers/line.c 2008-07-22 12:06:49.000000000 +0200 > >> @@ -362,10 +362,8 @@ static irqreturn_t line_write_interrupt( > >> if (tty == NULL) > >> return IRQ_NONE; > >> > >> - if (test_bit(TTY_DO_WRITE_WAKEUP, &tty->flags) && > >> - (tty->ldisc.write_wakeup != NULL)) > >> - (tty->ldisc.write_wakeup)(tty); > >> - > >> + if (test_bit(TTY_DO_WRITE_WAKEUP, &tty->flags)) > >> + tty_wakeup(tty); > > > >Sorry I should have been clearer - you don't want the test_bit either. > > > > What about the below one? > > Signed-off-by: WANG Cong Acked-by: Alan Cox -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/