Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754527AbYGVSL6 (ORCPT ); Tue, 22 Jul 2008 14:11:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752055AbYGVSLt (ORCPT ); Tue, 22 Jul 2008 14:11:49 -0400 Received: from palinux.external.hp.com ([192.25.206.14]:37630 "EHLO mail.parisc-linux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751554AbYGVSLs (ORCPT ); Tue, 22 Jul 2008 14:11:48 -0400 Date: Tue, 22 Jul 2008 12:11:32 -0600 From: Matthew Wilcox To: Eran Liberty Cc: eran liberty , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Jesse Barnes Subject: Re: [PATCH 2.6.26] PCI: refuse to re-add a device to a bus upon pci_scan_child_bus() Message-ID: <20080722181132.GE7337@parisc-linux.org> References: <48591941.4070408@extricom.com> <4884E0FB.9010909@extricom.com> <20080721194957.GH24246@parisc-linux.org> <20080722114929.GA7337@parisc-linux.org> <4885DD41.9010202@extricom.com> <20080722141327.GB7337@parisc-linux.org> <4885FBF4.6070306@extricom.com> <20080722165241.GD7337@parisc-linux.org> <48861BAC.1080009@extricom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48861BAC.1080009@extricom.com> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1088 Lines: 28 On Tue, Jul 22, 2008 at 08:41:00PM +0300, Eran Liberty wrote: > >>Do you perceive any down side to my suggested patch? > >>It seems (to me) really logical that a device can not and should not be > >>added twice to a pci bus device list. > >> > > > >The problem is the other side-effects of what you propose. > > > Could you elaborate what ominous side-effects you predict? Look at the consequences of calling fixup_resource() twice on the same resource: res->start = (res->start + offset) & mask; res->end = (res->end + offset) & mask; You'll add 'offset' to the other resources twice. -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/