Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754222AbYGVXf1 (ORCPT ); Tue, 22 Jul 2008 19:35:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758114AbYGVX1G (ORCPT ); Tue, 22 Jul 2008 19:27:06 -0400 Received: from yw-out-2324.google.com ([74.125.46.28]:33697 "EHLO yw-out-2324.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757319AbYGVX1D (ORCPT ); Tue, 22 Jul 2008 19:27:03 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references:x-google-sender-auth; b=Jcu2rfxN1J5M5M3XHzzpHWwZvyoixmu+2yMz/uyEzf8d0V03sSN3wAbuzeyInX9tBS SgRh/jtTPqtnsgONBc1ml/9eRFxKBrob7BK6UqAKjrUN1HB6fV4FdadiutHXWkVftHft 9sLCuXoe01KdGuhMBlneYch2qeC5foSDFCOMo= Message-ID: Date: Tue, 22 Jul 2008 16:27:02 -0700 From: "Dan Williams" To: "Brice Goglin" Subject: Re: [PATCH 1/2] I/OAT: Add watchdog/reset functionality to ioatdma driver Cc: "Maciej Sosnowski" , shannon.nelson@intel.com, linux-kernel@vger.kernel.org, net-dev@vger.kernel.org In-Reply-To: <48811047.1030509@inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080714132215.26830.90819.stgit@linux.site> <20080714132349.26830.22215.stgit@linux.site> <487B6004.6090801@inria.fr> <48811047.1030509@inria.fr> X-Google-Sender-Auth: 0f6e9f24bbfd2ad4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1113 Lines: 31 On Fri, Jul 18, 2008 at 2:51 PM, Brice Goglin wrote: > Dan Williams wrote: >>>> Sleep time in self_test has been increased to 10ms >>>> since in some cases 1ms appeared not to be enough >>> Thanks Maciej, this helps a lot here. >>> >> >> Can I interpret this as a "Tested-by" for the watchdog and/or the self_test fix? > > The sleep time increase to 10ms has been tested for a while (and helps a > lot here). > On my system I can still occasionally reproduce the self-test failure with this longer timeout. I think we should hold off on this band-aid patch until the root cause is found. We can get this fix in after the merge window closes. > I don't know about the watchdog yet. This one has been observed to fix the hang condition so I will include it in my upcoming pull request. Holler if your testing proves otherwise. Thanks, Dan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/