Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755262AbYGWAEf (ORCPT ); Tue, 22 Jul 2008 20:04:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752994AbYGWAE1 (ORCPT ); Tue, 22 Jul 2008 20:04:27 -0400 Received: from casper.infradead.org ([85.118.1.10]:59880 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752900AbYGWAE1 (ORCPT ); Tue, 22 Jul 2008 20:04:27 -0400 Date: Tue, 22 Jul 2008 17:02:16 -0700 From: Greg KH To: Andrew Morton Cc: david-b@pacbell.net, linux-kernel@vger.kernel.org, g.liakhovetski@pengutronix.de Subject: Re: [patch 2.6.26-rc5] gpio: sysfs interface (updated) Message-ID: <20080723000216.GB8203@kroah.com> References: <200806121153.36557.david-b@pacbell.net> <20080722162751.e8584d46.akpm@linux-foundation.org> <20080722232824.GA22596@kroah.com> <20080722165056.799223a7.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080722165056.799223a7.akpm@linux-foundation.org> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1445 Lines: 40 On Tue, Jul 22, 2008 at 04:50:56PM -0700, Andrew Morton wrote: > On Tue, 22 Jul 2008 16:28:24 -0700 > Greg KH wrote: > > > On Tue, Jul 22, 2008 at 04:27:51PM -0700, Andrew Morton wrote: > > > On Thu, 12 Jun 2008 11:53:36 -0700 > > > David Brownell wrote: > > > > > > > This adds a simple sysfs interface for GPIOs. > > > > > > device_create_drvdata() has magically vanished from today's linux-next, > > > so this code doesn't compile any more. > > > > > > This: > > > > > > --- a/drivers/gpio/gpiolib.c~gpio-sysfs-interface-updated-gpio-linux-next-fixes-for-sysfs-support-fix > > > +++ a/drivers/gpio/gpiolib.c > > > @@ -453,8 +453,8 @@ int gpio_export(unsigned gpio, bool dire > > > if (status == 0) { > > > struct device *dev; > > > > > > - dev = device_create_drvdata(&gpio_class, desc->chip->dev, 0, > > > - desc, "gpio%d", gpio); > > > + dev = device_create(&gpio_class, desc->chip->dev, 0, desc, > > > + "gpio%d", gpio); > > > > Should be NULL instead of 0 there, otherwise sparse will complain. > > The third arg to device_create is a dev_t, so 0 is correct Bah, sorry about that, MK_DEV(0,0) would be safer :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/