Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754389AbYGWOFH (ORCPT ); Wed, 23 Jul 2008 10:05:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753161AbYGWOEx (ORCPT ); Wed, 23 Jul 2008 10:04:53 -0400 Received: from relay.2ka.mipt.ru ([194.85.80.65]:59738 "EHLO 2ka.mipt.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752932AbYGWOEx (ORCPT ); Wed, 23 Jul 2008 10:04:53 -0400 Date: Wed, 23 Jul 2008 18:04:50 +0400 From: Evgeniy Polyakov To: Jerome Arbez-Gindre Cc: linux-kernel@vger.kernel.org, deweerdt@free.fr Subject: Re: New IDX in linux/connector.h ? Message-ID: <20080723140450.GA30991@2ka.mipt.ru> References: <20080723125307.GA12017@2ka.mipt.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1577 Lines: 43 On Wed, Jul 23, 2008 at 03:45:09PM +0200, Jerome Arbez-Gindre (jeromearbezgindre@gmail.com) wrote: > diff --git a/include/linux/connector.h b/include/linux/connector.h > index 96a89d3..361996c 100644 > --- a/include/linux/connector.h > +++ b/include/linux/connector.h > @@ -38,6 +38,7 @@ > #define CN_W1_VAL 0x1 > #define CN_IDX_V86D 0x4 > #define CN_VAL_V86D_UVESAFB 0x1 > +#define CN_IDX_BB 0x5 > > #define CN_NETLINK_USERS 5 Update this number too. While it is less than 32, it does not matter, but just for the record. > > I even wanted to have private indexes, i.e. those which are supposed to > > be used by out-of-the-tree code, and no in-kernel users would ever touch > > this numbers. > > So which numbers am I suppose to use ... taking account that BB will > probably stay for a long time out-of-the-tree ? You can use whatever VAL number you like: struct cb_id cn_dst_id[] = {{CN_DST_IDX, 1}, {CN_DST_IDX, 2}, {CN_DST_IDX, 3}}; for (i=0; i