Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S289926AbSAWRe7>; Wed, 23 Jan 2002 12:34:59 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S289927AbSAWRet>; Wed, 23 Jan 2002 12:34:49 -0500
Received: from mail.sonytel.be ([193.74.243.200]:22149 "EHLO mail.sonytel.be")
	by vger.kernel.org with ESMTP id <S289926AbSAWRek>;
	Wed, 23 Jan 2002 12:34:40 -0500
Date: Wed, 23 Jan 2002 18:34:03 +0100 (MET)
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Sven <luther@dpt-info.u-strasbg.fr>
cc: James Simmons <jsimmons@transvirtual.com>,
        Linux Fbdev development list 
	<linux-fbdev-devel@lists.sourceforge.net>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [Linux-fbdev-devel] [PATCH] fbdev fbgen cleanup
In-Reply-To: <20020123183102.A3780@dpt-info.u-strasbg.fr>
Message-ID: <Pine.GSO.4.21.0201231832560.26747-100000@vervain.sonytel.be>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 23 Jan 2002, Sven wrote:
> On Mon, Jan 21, 2002 at 09:03:25AM -0800, James Simmons wrote:
> > 
> > > BTW, romain, i have built pm3fb with 2.5.2, there were some modifications
> > > needed, the major of them was the testing for 2.2 or 2.4 kernels that needed
> > > changing, and the new info.node, which needed to be changed to
> > > info.node.values.
> > 
> > The correct fix is to do something like fb_info.node = NODEV;
> 
> And not B_FREE ?
> 
> I am unsure about this, but i notice that in the 2.4.17 kernel + pm3fb, the
> value assigned to .node was -1, which correspond to B_FREE and not NODEV
> (which is 0).
> 
> That said, since it is almost never used, it would maybe be best to move it
> out of the fbdevs and into some of the more generic layers.
> 
> Also, since when does the B_FREE or NODEV exists ? I did put the changes into
> a #ifdef kernel 2.5, and kept the -1 for kernels 2.4, but i guess i could
> remove this check altogether if the NODEV was present from the begining. And

IIRC, Marcelo added NODEV to 2.4.x in one of his latest releases, just to solve
this problem.

> what about 2.2 kernels ?

No idea. Ask Alan :-)

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/