Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752943AbYGXMlL (ORCPT ); Thu, 24 Jul 2008 08:41:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757492AbYGXMkn (ORCPT ); Thu, 24 Jul 2008 08:40:43 -0400 Received: from rv-out-0506.google.com ([209.85.198.233]:55377 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757478AbYGXMkl (ORCPT ); Thu, 24 Jul 2008 08:40:41 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references:x-google-sender-auth; b=ckvCeKItd0rUwcZNSJR7K0mYO7Uhowdt5IBAyDZcR98N69DCAYxux8pakUKpwk9p7k lTUPhIp5zqvqa7rBq9DsUYON+7Ta0bHCbk/+0mFn9TxU4RR0CO9GaRY4B95UaYOdZkiZ yk8EjtIF0wpMaZeKZCYdqGqEuDH3TSBrEAsX0= Message-ID: <84144f020807240540vbe7ef50uee2cacabe8016546@mail.gmail.com> Date: Thu, 24 Jul 2008 15:40:40 +0300 From: "Pekka Enberg" To: "Herbert Xu" Subject: Re: [regression] nf_iterate(), BUG: unable to handle kernel NULL pointer dereference Cc: "Patrick McHardy" , "Ingo Molnar" , "David Miller" , w@1wt.eu, davidn@davidnewall.com, torvalds@linux-foundation.org, akpm@linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stefanr@s5r6.in-berlin.de, rjw@sisk.pl, ilpo.jarvinen@helsinki.fi, "Dave Jones" , "Matt Mackall" , "Christoph Lameter" In-Reply-To: <20080724122203.GA7187@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080724060448.GA10203@elte.hu> <20080724.022259.113079007.davem@davemloft.net> <20080724093411.GA12001@elte.hu> <20080724115625.GA23994@elte.hu> <20080724115957.GA25701@elte.hu> <48886FA6.6050908@trash.net> <20080724122203.GA7187@gondor.apana.org.au> X-Google-Sender-Auth: 55468ad19d0eabcf Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 961 Lines: 23 Hi Herbert, On Thu, Jul 24, 2008 at 02:03:50PM +0200, Patrick McHardy wrote: >> Does reverting 31d8519c fix this? On Thu, Jul 24, 2008 at 3:22 PM, Herbert Xu wrote: > Regardless of whether this is the problem, banning ksize because > it can be abused is like banning cars because they can kill people. > > For example, Ethernet skbs are 1500 bytes long, so using ksize > we could potentially use the left-over memory for temporary storage. Using ksize() for skbs will crash your kernel for some configurations because calling that function for memory allocated with kmem_cache_alloc() is not supported by all the allocators (well, SLOB). Pekka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/