Return-Path: <linux-kernel-owner+w=401wt.eu-S1752505AbYGXNG4@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752505AbYGXNG4 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 24 Jul 2008 09:06:56 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752969AbYGXNGp
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Thu, 24 Jul 2008 09:06:45 -0400
Received: from rhun.apana.org.au ([64.62.148.172]:39073 "EHLO
	arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1751816AbYGXNGo (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 24 Jul 2008 09:06:44 -0400
From: Herbert Xu <herbert@gondor.apana.org.au>
To: davem@davemloft.net (David Miller)
Subject: Re: 2.6.26: [<c0133cc1>] __alloc_pages_internal+0x331/0x343
Cc: pupilla@hotmail.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Organization: Core
In-Reply-To: <20080723.234556.98132946.davem@davemloft.net>
X-Newsgroups: apana.lists.os.linux.kernel,apana.lists.os.linux.netdev
User-Agent: tin/1.7.4-20040225 ("Benbecula") (UNIX) (Linux/2.6.17-rc4 (i686))
Message-Id: <E1KM0Wl-0001zC-00@gondolin.me.apana.org.au>
Date: Thu, 24 Jul 2008 21:06:39 +0800
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1521
Lines: 36

David Miller <davem@davemloft.net> wrote:
> From: "Marco Berizzi" <pupilla@hotmail.com>
> Date: Thu, 24 Jul 2008 08:39:48 +0200
> 
>> Jul 23 12:40:02 Electra kernel: crond: page allocation failure. order:5,
>> mode:0x4020
>> Jul 23 12:40:02 Electra kernel: Pid: 586, comm: crond Not tainted 2.6.26
>> #1
>> Jul 23 12:40:02 Electra kernel:  [<c0135e93>]
>> __alloc_pages_internal+0x226/0x393
>> Jul 23 12:40:02 Electra kernel:  [<c0136007>] __alloc_pages+0x7/0x9
>> Jul 23 12:40:02 Electra kernel:  [<c013602a>] __get_free_pages+0x16/0x32
>> Jul 23 12:40:03 Electra kernel:  [<c024d2a5>]
>> pskb_expand_head+0x41/0x164
>> Jul 23 12:40:03 Electra kernel:  [<c029a6b4>]
>> ipcomp_decompress+0x60/0xa1
> 
> ipcomp_decompress() should probably be changed to try and build
> a scatterlist of pages for the resulting packet SKB data instead
> of building a linear buffer as it does now.

Indeed, this is long overdue.  I'm going to spend a few cycles on
this.  I'll start by moving the common code into net/xfrm/ipcomp.c
so that I don't have to do it twice later.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/