Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757440AbYGXPeW (ORCPT ); Thu, 24 Jul 2008 11:34:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753789AbYGXPeK (ORCPT ); Thu, 24 Jul 2008 11:34:10 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:40883 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753104AbYGXPeI (ORCPT ); Thu, 24 Jul 2008 11:34:08 -0400 Date: Thu, 24 Jul 2008 17:32:48 +0200 From: Ingo Molnar To: Patrick McHardy Cc: David Miller , herbert@gondor.apana.org.au, w@1wt.eu, davidn@davidnewall.com, torvalds@linux-foundation.org, akpm@linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stefanr@s5r6.in-berlin.de, rjw@sisk.pl, ilpo.jarvinen@helsinki.fi, Dave Jones , Krzysztof Piotr Oledzki Subject: Re: [regression] nf_iterate(), BUG: unable to handle kernel NULL pointer dereference Message-ID: <20080724153248.GA25056@elte.hu> References: <20080724060448.GA10203@elte.hu> <20080724.022259.113079007.davem@davemloft.net> <20080724093411.GA12001@elte.hu> <20080724115625.GA23994@elte.hu> <20080724115957.GA25701@elte.hu> <20080724142353.GA400@elte.hu> <48889E57.2000007@trash.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48889E57.2000007@trash.net> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2122 Lines: 53 * Patrick McHardy wrote: > Ingo Molnar wrote: >> Then i tried both suggested fix patches Patrick sent me (a suggested >> revert and an netfilter/RCU use-after-free fix), but none of them >> solved the crash. > > Just to make sure - the "netfilter/RCU use-after-free fix" was the > patch from Pekka? yes. You can see it in tip/out-of-tree: http://people.redhat.com/mingo/tip.git/README >> Thus i finally arrived to: >> >> # good: [ae6134bd] hdlcdrv: Fix CRC calculation. >> # bad: [5547cd0d] netfilter: nf_conntrack_sctp: fix sparse warnings >> # bad: [280763c6] netfilter: xt_time: fix time's time_mt()'s use of >> # good: [07a7c10b] netlink: add NLA_PUT_BE64 macro >> # bad: [58401573] netfilter: accounting rework: ct_extend + 64bit co >> >> | 584015727a3b88b46602b20077b46cd04f8b4ab3 is first bad commit >> | commit 584015727a3b88b46602b20077b46cd04f8b4ab3 >> | Author: Krzysztof Piotr Oledzki >> | AuthorDate: Mon Jul 21 10:01:34 2008 -0700 >> | Commit: David S. Miller >> | CommitDate: Mon Jul 21 10:10:58 2008 -0700 >> | >> | netfilter: accounting rework: ct_extend + 64bit counters (v4) >> [...] >> | Signed-off-by: Krzysztof Piotr Oledzki >> | Signed-off-by: Patrick McHardy >> | Signed-off-by: David S. Miller >> >> Which i double-checked by reverting that commit from -git as well and >> that solved the crash. Find the tested reverter patch below. > > Thats odd. I don't think anything is wrong with that patch itself, its > more likely that its triggering a bug in ct_extend. You config has a > few helper enabled (FTP, H.323, TFTP) and the crash is when trying to > call the helper functions. Did you actually have traffic of one of > these protocols? no, that's not likely - it's a default distro bootup. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/