Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754152AbYGXSJx (ORCPT ); Thu, 24 Jul 2008 14:09:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752035AbYGXSJl (ORCPT ); Thu, 24 Jul 2008 14:09:41 -0400 Received: from bizon.gios.gov.pl ([212.244.124.8]:56401 "EHLO bizon.gios.gov.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752023AbYGXSJk (ORCPT ); Thu, 24 Jul 2008 14:09:40 -0400 Date: Thu, 24 Jul 2008 20:00:26 +0200 (CEST) From: Krzysztof Oledzki X-X-Sender: ole@bizon.gios.gov.pl To: Ingo Molnar cc: Patrick McHardy , David Miller , herbert@gondor.apana.org.au, w@1wt.eu, davidn@davidnewall.com, torvalds@linux-foundation.org, akpm@linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stefanr@s5r6.in-berlin.de, rjw@sisk.pl, ilpo.jarvinen@helsinki.fi, Dave Jones Subject: Re: [regression] nf_iterate(), BUG: unable to handle kernel NULL pointer dereference In-Reply-To: <20080724153248.GA25056@elte.hu> Message-ID: References: <20080724060448.GA10203@elte.hu> <20080724.022259.113079007.davem@davemloft.net> <20080724093411.GA12001@elte.hu> <20080724115625.GA23994@elte.hu> <20080724115957.GA25701@elte.hu> <20080724142353.GA400@elte.hu> <48889E57.2000007@trash.net> <20080724153248.GA25056@elte.hu> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="-187430788-385197319-1216922426=:1907" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2750 Lines: 71 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---187430788-385197319-1216922426=:1907 Content-Type: TEXT/PLAIN; charset=ISO-8859-2; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE On Thu, 24 Jul 2008, Ingo Molnar wrote: > > * Patrick McHardy wrote: > >> Ingo Molnar wrote: >>> Then i tried both suggested fix patches Patrick sent me (a suggested >>> revert and an netfilter/RCU use-after-free fix), but none of them >>> solved the crash. >> >> Just to make sure - the "netfilter/RCU use-after-free fix" was the >> patch from Pekka? > > yes. You can see it in tip/out-of-tree: > > http://people.redhat.com/mingo/tip.git/README > >>> Thus i finally arrived to: >>> >>> # good: [ae6134bd] hdlcdrv: Fix CRC calculation. >>> # bad: [5547cd0d] netfilter: nf_conntrack_sctp: fix sparse warnings >>> # bad: [280763c6] netfilter: xt_time: fix time's time_mt()'s use of >>> # good: [07a7c10b] netlink: add NLA_PUT_BE64 macro >>> # bad: [58401573] netfilter: accounting rework: ct_extend + 64bit co >>> >>> | 584015727a3b88b46602b20077b46cd04f8b4ab3 is first bad commit >>> | commit 584015727a3b88b46602b20077b46cd04f8b4ab3 >>> | Author: Krzysztof Piotr Oledzki >>> | AuthorDate: Mon Jul 21 10:01:34 2008 -0700 >>> | Commit: David S. Miller >>> | CommitDate: Mon Jul 21 10:10:58 2008 -0700 >>> | >>> | netfilter: accounting rework: ct_extend + 64bit counters (v4) >>> [...] >>> | Signed-off-by: Krzysztof Piotr Oledzki >>> | Signed-off-by: Patrick McHardy >>> | Signed-off-by: David S. Miller >>> >>> Which i double-checked by reverting that commit from -git as well and >>> that solved the crash. Find the tested reverter patch below. >> >> Thats odd. I don't think anything is wrong with that patch itself, its >> more likely that its triggering a bug in ct_extend. You config has a >> few helper enabled (FTP, H.323, TFTP) and the crash is when trying to >> call the helper functions. Did you actually have traffic of one of >> these protocols? > > no, that's not likely - it's a default distro bootup. The commit makes ct_extend area to be used *very* frequently. Could you=20 try to boot your kernel with nf_conntrack.acct=3D0 to disable accounting? Does it help? Best regards, =09=09=09=09Krzysztof Ol=EAdzki ---187430788-385197319-1216922426=:1907-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/