Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755751AbYGXXIo (ORCPT ); Thu, 24 Jul 2008 19:08:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755260AbYGXXIa (ORCPT ); Thu, 24 Jul 2008 19:08:30 -0400 Received: from g4t0016.houston.hp.com ([15.201.24.19]:6625 "EHLO g4t0016.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755044AbYGXXI3 (ORCPT ); Thu, 24 Jul 2008 19:08:29 -0400 Date: Thu, 24 Jul 2008 17:08:27 -0600 From: Alex Chiang To: Pierre Ossman Cc: Jesse Barnes , Kenji Kaneshige , LKML , linux-pci@vger.kernel.org Subject: Re: post 2.6.26 requires pciehp_slot_with_bus Message-ID: <20080724230827.GA30302@ldl.fc.hp.com> Mail-Followup-To: Alex Chiang , Pierre Ossman , Jesse Barnes , Kenji Kaneshige , LKML , linux-pci@vger.kernel.org References: <20080724134737.4b91f30d@mjolnir.drzeus.cx> <200807241407.18543.jbarnes@virtuousgeek.org> <20080724235127.40bd0ac9@mjolnir.drzeus.cx> <200807241506.58973.jbarnes@virtuousgeek.org> <20080724222914.GG5307@ldl.fc.hp.com> <20080725004926.5f201c70@mjolnir.drzeus.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080725004926.5f201c70@mjolnir.drzeus.cx> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 16135 Lines: 290 * Pierre Ossman : > On Thu, 24 Jul 2008 16:29:14 -0600 > Alex Chiang wrote: > > > * Jesse Barnes : > > > > > > Theoretically only one of the other hotplug drivers could claim > > > the slot (e.g. acpi, cpci, cpqhp, fakephp etc.). You could > > > put a dump_stack() or something into > > > drivers/pci/hotplug/pci_hotplug_core.c:pci_hp_register to see > > > if we're getting multiple callers on the same slot for some > > > reason... Maybe the pciehp driver itself is trying to register > > > the same slot twice? > > > > This is a good idea. > > > > Any chance you could get that debug info for us, Pierre? > > > > I aim to please. Following is the relevant lines from my bootup with a > dump_stack() right at the beginning of pci_hp_register(): Sorry for one more round-trip, but could you turn on debugging for pciehp as well? You're building it into your kernel right? I think you need to boot with pciehp_debug=1. Thanks. /ac > > [ 1.247459] pcieport-driver 0000:00:01.0: found MSI capability > [ 1.247523] pci_express 0000:00:01.0:pcie00: allocate port service > [ 1.247632] pci_express 0000:00:01.0:pcie02: allocate port service > [ 1.247741] pci_express 0000:00:01.0:pcie03: allocate port service > [ 1.248010] PCI: Setting latency timer of device 0000:00:1c.0 to 64 > [ 1.248158] pcieport-driver 0000:00:1c.0: found MSI capability > [ 1.248299] pci_express 0000:00:1c.0:pcie00: allocate port service > [ 1.248415] pci_express 0000:00:1c.0:pcie02: allocate port service > [ 1.248524] pci_express 0000:00:1c.0:pcie03: allocate port service > [ 1.248873] PCI: Setting latency timer of device 0000:00:1c.1 to 64 > [ 1.249020] pcieport-driver 0000:00:1c.1: found MSI capability > [ 1.249162] pci_express 0000:00:1c.1:pcie00: allocate port service > [ 1.249270] pci_express 0000:00:1c.1:pcie02: allocate port service > [ 1.249379] pci_express 0000:00:1c.1:pcie03: allocate port service > [ 1.249708] PCI: Setting latency timer of device 0000:00:1c.2 to 64 > [ 1.249855] pcieport-driver 0000:00:1c.2: found MSI capability > [ 1.249995] pci_express 0000:00:1c.2:pcie00: allocate port service > [ 1.250102] pci_express 0000:00:1c.2:pcie02: allocate port service > [ 1.250211] pci_express 0000:00:1c.2:pcie03: allocate port service > [ 1.250531] PCI: Setting latency timer of device 0000:00:1c.3 to 64 > [ 1.250679] pcieport-driver 0000:00:1c.3: found MSI capability > [ 1.250819] pci_express 0000:00:1c.3:pcie00: allocate port service > [ 1.250927] pci_express 0000:00:1c.3:pcie02: allocate port service > [ 1.251035] pci_express 0000:00:1c.3:pcie03: allocate port service > [ 1.251361] PCI: Setting latency timer of device 0000:00:1c.4 to 64 > [ 1.251508] pcieport-driver 0000:00:1c.4: found MSI capability > [ 1.251649] pci_express 0000:00:1c.4:pcie00: allocate port service > [ 1.251762] pci_express 0000:00:1c.4:pcie02: allocate port service > [ 1.251894] pci_express 0000:00:1c.4:pcie03: allocate port service > [ 1.252429] pci_hotplug: PCI Hot Plug PCI Core version: 0.5 > [ 1.253405] pciehp: HPC vendor_id 8086 device_id 2a01 ss_vid 0 ss_did 0 > [ 1.253453] Pid: 1, comm: swapper Not tainted 2.6.26 #110 > [ 1.253460] [] pci_hp_register+0x25/0x4b0 > [ 1.253475] [] ? get_adapter_status+0x2e/0x70 > [ 1.253485] [] ? pciehp_probe+0xbd/0x3f0 > [ 1.253494] [] pciehp_probe+0x12b/0x3f0 > [ 1.253502] [] ? sysfs_add_one+0x18/0x50 > [ 1.253513] [] ? sysfs_do_create_link+0xa4/0x140 > [ 1.253523] [] pcie_port_probe_service+0x50/0x90 > [ 1.253531] [] ? sysfs_create_link+0x17/0x20 > [ 1.253540] [] ? driver_sysfs_add+0x5d/0x90 > [ 1.253550] [] driver_probe_device+0x87/0x1a0 > [ 1.253557] [] ? _spin_lock_irqsave+0x21/0x40 > [ 1.253569] [] ? _spin_unlock_irqrestore+0x16/0x40 > [ 1.253578] [] __driver_attach+0x79/0x80 > [ 1.253585] [] bus_for_each_dev+0x53/0x80 > [ 1.253593] [] driver_attach+0x1e/0x20 > [ 1.253600] [] ? __driver_attach+0x0/0x80 > [ 1.253608] [] bus_add_driver+0x1b7/0x230 > [ 1.253615] [] driver_register+0x6e/0x150 > [ 1.253622] [] ? driver_register+0x6e/0x150 > [ 1.253630] [] pcie_port_service_register+0x3f/0x50 > [ 1.253638] [] pcied_init+0x16/0x83 > [ 1.253648] [] ? pci_hotplug_init+0x1f/0x23 > [ 1.253657] [] kernel_init+0x1ad/0x2b8 > [ 1.253666] [] ? sys_select+0x44/0x1a0 > [ 1.253676] [] ? pcied_init+0x0/0x83 > [ 1.253685] [] ? schedule_tail+0x1f/0x50 > [ 1.253695] [] ? ret_from_fork+0x6/0x1c > [ 1.253704] [] ? kernel_init+0x0/0x2b8 > [ 1.253712] [] ? kernel_init+0x0/0x2b8 > [ 1.253720] [] kernel_thread_helper+0x7/0x10 > [ 1.253728] ======================= > [ 1.253841] hpdriver 0000:00:01.0:pcie02: service driver hpdriver loaded > [ 1.254648] pciehp: HPC vendor_id 8086 device_id 283f ss_vid 0 ss_did 0 > [ 1.254730] Pid: 1, comm: swapper Not tainted 2.6.26 #110 > [ 1.254735] [] pci_hp_register+0x25/0x4b0 > [ 1.254744] [] ? get_adapter_status+0x2e/0x70 > [ 1.254754] [] ? pciehp_probe+0xbd/0x3f0 > [ 1.254763] [] pciehp_probe+0x12b/0x3f0 > [ 1.254771] [] ? sysfs_add_one+0x18/0x50 > [ 1.254780] [] ? sysfs_do_create_link+0xa4/0x140 > [ 1.254789] [] pcie_port_probe_service+0x50/0x90 > [ 1.254797] [] ? sysfs_create_link+0x17/0x20 > [ 1.254806] [] ? driver_sysfs_add+0x5d/0x90 > [ 1.254814] [] driver_probe_device+0x87/0x1a0 > [ 1.254821] [] ? _spin_lock_irqsave+0x21/0x40 > [ 1.254830] [] ? _spin_unlock_irqrestore+0x16/0x40 > [ 1.254838] [] __driver_attach+0x79/0x80 > [ 1.254845] [] bus_for_each_dev+0x53/0x80 > [ 1.254853] [] driver_attach+0x1e/0x20 > [ 1.254859] [] ? __driver_attach+0x0/0x80 > [ 1.254867] [] bus_add_driver+0x1b7/0x230 > [ 1.254874] [] driver_register+0x6e/0x150 > [ 1.254881] [] ? driver_register+0x6e/0x150 > [ 1.254889] [] pcie_port_service_register+0x3f/0x50 > [ 1.254897] [] pcied_init+0x16/0x83 > [ 1.254905] [] ? pci_hotplug_init+0x1f/0x23 > [ 1.254914] [] kernel_init+0x1ad/0x2b8 > [ 1.254922] [] ? sys_select+0x44/0x1a0 > [ 1.254930] [] ? pcied_init+0x0/0x83 > [ 1.254939] [] ? schedule_tail+0x1f/0x50 > [ 1.254948] [] ? ret_from_fork+0x6/0x1c > [ 1.254956] [] ? kernel_init+0x0/0x2b8 > [ 1.254964] [] ? kernel_init+0x0/0x2b8 > [ 1.254972] [] kernel_thread_helper+0x7/0x10 > [ 1.254980] ======================= > [ 1.255097] hpdriver 0000:00:1c.0:pcie02: service driver hpdriver loaded > [ 1.255900] pciehp: HPC vendor_id 8086 device_id 2841 ss_vid 0 ss_did 0 > [ 1.255989] Pid: 1, comm: swapper Not tainted 2.6.26 #110 > [ 1.255994] [] pci_hp_register+0x25/0x4b0 > [ 1.256004] [] ? get_adapter_status+0x2e/0x70 > [ 1.256013] [] ? pciehp_probe+0xbd/0x3f0 > [ 1.256023] [] pciehp_probe+0x12b/0x3f0 > [ 1.256030] [] ? sysfs_add_one+0x18/0x50 > [ 1.256040] [] ? sysfs_do_create_link+0xa4/0x140 > [ 1.256049] [] pcie_port_probe_service+0x50/0x90 > [ 1.256057] [] ? sysfs_create_link+0x17/0x20 > [ 1.256066] [] ? driver_sysfs_add+0x5d/0x90 > [ 1.256074] [] driver_probe_device+0x87/0x1a0 > [ 1.256082] [] ? _spin_lock_irqsave+0x21/0x40 > [ 1.256092] [] ? _spin_unlock_irqrestore+0x16/0x40 > [ 1.256100] [] __driver_attach+0x79/0x80 > [ 1.256107] [] bus_for_each_dev+0x53/0x80 > [ 1.256114] [] driver_attach+0x1e/0x20 > [ 1.256121] [] ? __driver_attach+0x0/0x80 > [ 1.256129] [] bus_add_driver+0x1b7/0x230 > [ 1.256136] [] driver_register+0x6e/0x150 > [ 1.256143] [] ? driver_register+0x6e/0x150 > [ 1.256151] [] pcie_port_service_register+0x3f/0x50 > [ 1.256159] [] pcied_init+0x16/0x83 > [ 1.256167] [] ? pci_hotplug_init+0x1f/0x23 > [ 1.256176] [] kernel_init+0x1ad/0x2b8 > [ 1.256184] [] ? sys_select+0x44/0x1a0 > [ 1.256192] [] ? pcied_init+0x0/0x83 > [ 1.256201] [] ? schedule_tail+0x1f/0x50 > [ 1.256209] [] ? ret_from_fork+0x6/0x1c > [ 1.256218] [] ? kernel_init+0x0/0x2b8 > [ 1.256226] [] ? kernel_init+0x0/0x2b8 > [ 1.256234] [] kernel_thread_helper+0x7/0x10 > [ 1.256242] ======================= > [ 1.256355] hpdriver 0000:00:1c.1:pcie02: service driver hpdriver loaded > [ 1.257191] pciehp: HPC vendor_id 8086 device_id 2843 ss_vid 0 ss_did 0 > [ 1.257273] Pid: 1, comm: swapper Not tainted 2.6.26 #110 > [ 1.257278] [] pci_hp_register+0x25/0x4b0 > [ 1.257287] [] ? get_adapter_status+0x2e/0x70 > [ 1.257297] [] ? pciehp_probe+0xbd/0x3f0 > [ 1.257306] [] pciehp_probe+0x12b/0x3f0 > [ 1.257313] [] ? sysfs_add_one+0x18/0x50 > [ 1.257323] [] ? sysfs_do_create_link+0xa4/0x140 > [ 1.257332] [] pcie_port_probe_service+0x50/0x90 > [ 1.257340] [] ? sysfs_create_link+0x17/0x20 > [ 1.257349] [] ? driver_sysfs_add+0x5d/0x90 > [ 1.257358] [] driver_probe_device+0x87/0x1a0 > [ 1.257365] [] ? _spin_lock_irqsave+0x21/0x40 > [ 1.257374] [] ? _spin_unlock_irqrestore+0x16/0x40 > [ 1.257383] [] __driver_attach+0x79/0x80 > [ 1.257390] [] bus_for_each_dev+0x53/0x80 > [ 1.257397] [] driver_attach+0x1e/0x20 > [ 1.257403] [] ? __driver_attach+0x0/0x80 > [ 1.257411] [] bus_add_driver+0x1b7/0x230 > [ 1.257419] [] driver_register+0x6e/0x150 > [ 1.257426] [] ? driver_register+0x6e/0x150 > [ 1.257434] [] pcie_port_service_register+0x3f/0x50 > [ 1.257442] [] pcied_init+0x16/0x83 > [ 1.257450] [] ? pci_hotplug_init+0x1f/0x23 > [ 1.257459] [] kernel_init+0x1ad/0x2b8 > [ 1.257467] [] ? sys_select+0x44/0x1a0 > [ 1.257475] [] ? pcied_init+0x0/0x83 > [ 1.257484] [] ? schedule_tail+0x1f/0x50 > [ 1.257492] [] ? ret_from_fork+0x6/0x1c > [ 1.257500] [] ? kernel_init+0x0/0x2b8 > [ 1.257509] [] ? kernel_init+0x0/0x2b8 > [ 1.257517] [] kernel_thread_helper+0x7/0x10 > [ 1.257524] ======================= > [ 1.257639] hpdriver 0000:00:1c.2:pcie02: service driver hpdriver loaded > [ 1.258440] pciehp: HPC vendor_id 8086 device_id 2845 ss_vid 0 ss_did 0 > [ 1.258522] Pid: 1, comm: swapper Not tainted 2.6.26 #110 > [ 1.258527] [] pci_hp_register+0x25/0x4b0 > [ 1.258537] [] ? get_adapter_status+0x2e/0x70 > [ 1.258546] [] ? pciehp_probe+0xbd/0x3f0 > [ 1.258556] [] pciehp_probe+0x12b/0x3f0 > [ 1.258564] [] ? sysfs_add_one+0x18/0x50 > [ 1.258573] [] ? sysfs_do_create_link+0xa4/0x140 > [ 1.258583] [] pcie_port_probe_service+0x50/0x90 > [ 1.258591] [] ? sysfs_create_link+0x17/0x20 > [ 1.258600] [] ? driver_sysfs_add+0x5d/0x90 > [ 1.258609] [] driver_probe_device+0x87/0x1a0 > [ 1.258616] [] ? _spin_lock_irqsave+0x21/0x40 > [ 1.258626] [] ? _spin_unlock_irqrestore+0x16/0x40 > [ 1.258634] [] __driver_attach+0x79/0x80 > [ 1.258642] [] bus_for_each_dev+0x53/0x80 > [ 1.258649] [] driver_attach+0x1e/0x20 > [ 1.258656] [] ? __driver_attach+0x0/0x80 > [ 1.258665] [] bus_add_driver+0x1b7/0x230 > [ 1.258672] [] driver_register+0x6e/0x150 > [ 1.258679] [] ? driver_register+0x6e/0x150 > [ 1.258687] [] pcie_port_service_register+0x3f/0x50 > [ 1.258695] [] pcied_init+0x16/0x83 > [ 1.258703] [] ? pci_hotplug_init+0x1f/0x23 > [ 1.258712] [] kernel_init+0x1ad/0x2b8 > [ 1.258719] [] ? sys_select+0x44/0x1a0 > [ 1.258728] [] ? pcied_init+0x0/0x83 > [ 1.258737] [] ? schedule_tail+0x1f/0x50 > [ 1.258745] [] ? ret_from_fork+0x6/0x1c > [ 1.258753] [] ? kernel_init+0x0/0x2b8 > [ 1.258761] [] ? kernel_init+0x0/0x2b8 > [ 1.258769] [] kernel_thread_helper+0x7/0x10 > [ 1.258777] ======================= > [ 1.258893] hpdriver 0000:00:1c.3:pcie02: service driver hpdriver loaded > [ 1.259701] pciehp: HPC vendor_id 8086 device_id 2847 ss_vid 0 ss_did 0 > [ 1.259787] Pid: 1, comm: swapper Not tainted 2.6.26 #110 > [ 1.259791] [] pci_hp_register+0x25/0x4b0 > [ 1.259801] [] ? get_adapter_status+0x2e/0x70 > [ 1.259810] [] ? pciehp_probe+0xbd/0x3f0 > [ 1.259819] [] pciehp_probe+0x12b/0x3f0 > [ 1.259827] [] ? sysfs_add_one+0x18/0x50 > [ 1.259836] [] ? sysfs_do_create_link+0xa4/0x140 > [ 1.259845] [] pcie_port_probe_service+0x50/0x90 > [ 1.259853] [] ? sysfs_create_link+0x17/0x20 > [ 1.259862] [] ? driver_sysfs_add+0x5d/0x90 > [ 1.259870] [] driver_probe_device+0x87/0x1a0 > [ 1.259877] [] ? _spin_lock_irqsave+0x21/0x40 > [ 1.259886] [] ? _spin_unlock_irqrestore+0x16/0x40 > [ 1.259894] [] __driver_attach+0x79/0x80 > [ 1.259901] [] bus_for_each_dev+0x53/0x80 > [ 1.259908] [] driver_attach+0x1e/0x20 > [ 1.259915] [] ? __driver_attach+0x0/0x80 > [ 1.259923] [] bus_add_driver+0x1b7/0x230 > [ 1.259930] [] driver_register+0x6e/0x150 > [ 1.259937] [] ? driver_register+0x6e/0x150 > [ 1.259945] [] pcie_port_service_register+0x3f/0x50 > [ 1.259954] [] pcied_init+0x16/0x83 > [ 1.259962] [] ? pci_hotplug_init+0x1f/0x23 > [ 1.259971] [] kernel_init+0x1ad/0x2b8 > [ 1.259978] [] ? sys_select+0x44/0x1a0 > [ 1.259987] [] ? pcied_init+0x0/0x83 > [ 1.259996] [] ? schedule_tail+0x1f/0x50 > [ 1.260004] [] ? ret_from_fork+0x6/0x1c > [ 1.260012] [] ? kernel_init+0x0/0x2b8 > [ 1.260020] [] ? kernel_init+0x0/0x2b8 > [ 1.260028] [] kernel_thread_helper+0x7/0x10 > [ 1.260036] ======================= > [ 1.260041] pciehp: pci_hp_register failed with error -17 > [ 1.260176] pciehp: Failed to register slot because of name collision. Try 'pciehp_slot_with_bus' module option. > [ 1.260318] pciehp: pciehp: slot initialization failed > [ 1.260576] pciehp: PCI Express Hot Plug Controller Driver version: 0.4 > > > -- > -- Pierre Ossman > > Linux kernel, MMC maintainer http://www.kernel.org > rdesktop, core developer http://www.rdesktop.org > > WARNING: This correspondence is being monitored by the > Swedish government. Make sure your server uses encryption > for SMTP traffic and consider using PGP for end-to-end > encryption. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/