Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755408AbYGYAuh (ORCPT ); Thu, 24 Jul 2008 20:50:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753323AbYGYAu2 (ORCPT ); Thu, 24 Jul 2008 20:50:28 -0400 Received: from smtp116.sbc.mail.sp1.yahoo.com ([69.147.64.89]:24324 "HELO smtp116.sbc.mail.sp1.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753251AbYGYAu1 (ORCPT ); Thu, 24 Jul 2008 20:50:27 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=pacbell.net; h=Received:X-Yahoo-Newman-Property:From:To:Subject:Date:User-Agent:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id; b=bQroasujPAb9BorV8AM5DU0/U0HzzYoEYWE0EXSodYqWYSdvHkHIg+enX1w/DOMwzM0d/mGDs8OW/83vyx+lhId8KXOuNt/ms91zE0wy7kHM43E1R1vd3cpIdvtpIh1kUmC+lg/vfAgQuEJbokKCLYYaM1MnSjiGBZFVVkFiJZw= ; X-Yahoo-Newman-Property: ymail-3 From: David Brownell To: Uwe =?iso-8859-1?q?Kleine-K=F6nig?= , lkml Subject: [patch 2.6.26-git] genirq: better warning on irqchip->set_type() failure Date: Thu, 24 Jul 2008 17:50:25 -0700 User-Agent: KMail/1.9.9 Cc: Ingo Molnar , Andrew Morton MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200807241750.25507.david-b@pacbell.net> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1025 Lines: 27 From: David Brownell While I'm glad to finally see the hole fixed whereby passing an invalid IRQ trigger type to request_irq() would be ignored, the current diagnostic isn't quite useful. Fixed by also listing the trigger type which was rejected. Signed-off-by: David Brownell --- a/kernel/irq/manage.c +++ b/kernel/irq/manage.c @@ -326,8 +326,8 @@ static int __irq_set_trigger(struct irq_chip *chip, unsigned int irq, ret = chip->set_type(irq, flags & IRQF_TRIGGER_MASK); if (ret) - pr_err("setting flow type for irq %u failed (%pF)\n", - irq, chip->set_type); + pr_err("setting trigger type %d for irq %u failed (%pF)\n", + flags & IRQF_TRIGGER_MASK, irq, chip->set_type); return ret; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/