Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754189AbYGYGZd (ORCPT ); Fri, 25 Jul 2008 02:25:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751819AbYGYGZX (ORCPT ); Fri, 25 Jul 2008 02:25:23 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:42140 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751477AbYGYGZW (ORCPT ); Fri, 25 Jul 2008 02:25:22 -0400 Date: Thu, 24 Jul 2008 23:25:21 -0700 (PDT) Message-Id: <20080724.232521.193699299.davem@davemloft.net> To: mingo@elte.hu Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ecashin@coraid.com, axboe@suse.de, mike.miller@hp.com, a.p.zijlstra@chello.nl, rjw@sisk.pl Subject: Re: [lockdep warning] AOE / networking: aoenet_xmit: noop_qdisc.q.lock, INFO: inconsistent lock state at 0000000000000370 From: David Miller In-Reply-To: <20080725062009.GA6476@elte.hu> References: <20080721.134608.75595942.davem@davemloft.net> <20080725062009.GA6476@elte.hu> X-Mailer: Mew version 5.2 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 957 Lines: 29 From: Ingo Molnar Date: Fri, 25 Jul 2008 08:20:09 +0200 > not sure whether it got reported already, but -tip testing triggered > this new ATA over Ethernet lockdep warning on latest -git: Thanks for the report, does this fix it? diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c index 4ac7e3a..43abd4d 100644 --- a/net/sched/sch_generic.c +++ b/net/sched/sch_generic.c @@ -736,9 +736,9 @@ static void shutdown_scheduler_queue(struct net_device *dev, dev_queue->qdisc = qdisc_default; dev_queue->qdisc_sleeping = qdisc_default; - spin_lock(root_lock); + spin_lock_bh(root_lock); qdisc_destroy(qdisc); - spin_unlock(root_lock); + spin_unlock_bh(root_lock); } } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/