Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754541AbYGYHvg (ORCPT ); Fri, 25 Jul 2008 03:51:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752249AbYGYHv1 (ORCPT ); Fri, 25 Jul 2008 03:51:27 -0400 Received: from gate.crashing.org ([63.228.1.57]:46109 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751908AbYGYHv1 (ORCPT ); Fri, 25 Jul 2008 03:51:27 -0400 Subject: Re: sfx.c driver build failure From: Benjamin Herrenschmidt Reply-To: benh@kernel.crashing.org To: Michael Brown Cc: Linux Kernel list , linuxppc-dev list , Jeff Garzik In-Reply-To: References: <1216966559.11188.85.camel@pasglop> Content-Type: text/plain; charset=utf-8 Date: Fri, 25 Jul 2008 17:50:57 +1000 Message-Id: <1216972257.11188.96.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.22.2 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1092 Lines: 27 On Fri, 2008-07-25 at 08:35 +0100, Michael Brown wrote: > On Fri, 25 Jul 2008, Benjamin Herrenschmidt wrote: > > The sfx driver (which happens to be part of some of our test configs) > > fails to build in current Linus tree on powerpc with this error: > > > > /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c: In function ÿÿefx_probe_interruptsÿÿ: > > /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c:845: error: lvalue required as unary ÿÿ&ÿÿ oper > > and > > I'm not the maintainer of that code; I wrote the original version, but > it's now maintained by Solarflare. > > I don't see anything on that line that ought to be architecture-specific. > Could you send me the preprocessed efx.c from your powerpc build? Apparently, it's a know generic breakage of the topology stuff, it's beeing sorted out. Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/