Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755316AbYGYIkX (ORCPT ); Fri, 25 Jul 2008 04:40:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752566AbYGYIkK (ORCPT ); Fri, 25 Jul 2008 04:40:10 -0400 Received: from smtp6.pp.htv.fi ([213.243.153.40]:39770 "EHLO smtp6.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750927AbYGYIkI (ORCPT ); Fri, 25 Jul 2008 04:40:08 -0400 Date: Fri, 25 Jul 2008 11:39:43 +0300 From: Adrian Bunk To: Andrea Righi , Andrew Morton , Linus Torvalds Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: PAGE_ALIGN() compile breakage Message-ID: <20080725083943.GC19310@cs181140183.pp.htv.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1552 Lines: 42 Commit 27ac792ca0b0a1e7e65f20342260650516c95864 (PAGE_ALIGN(): correctly handle 64-bit values on 32-bit architectures) causes on some architectures (e.g. avr32 and mips) compile errors like the following in some configurations starting with: <-- snip --> ... CC init/main.o In file included from /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/utsname.h:35, from /home/bunk/linux/kernel-2.6/git/linux-2.6/init/main.c:20: /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/sched.h: In function 'arch_pick_mmap_layout': /home/bunk/linux/kernel-2.6/git/linux-2.6/include/linux/sched.h:2149: error: implicit declaration of function 'PAGE_ALIGN' make[2]: *** [init/main.o] Error 1 <-- snip --> and more nasty problems follow later. My suggestion is to: - revert commit 27ac792ca0b0a1e7e65f20342260650516c95864 and then - fix all PAGE_ALIGN() instances without moving them. Unifying code is a good thing, but in this case it is not worth the trouble it causes by poking into the heart of our headers mess. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/