Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755404AbYGYJ0j (ORCPT ); Fri, 25 Jul 2008 05:26:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753251AbYGYJ02 (ORCPT ); Fri, 25 Jul 2008 05:26:28 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:40986 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753108AbYGYJ01 (ORCPT ); Fri, 25 Jul 2008 05:26:27 -0400 Date: Fri, 25 Jul 2008 02:25:47 -0700 From: Andrew Morton To: Adrian Bunk Cc: Andrea Righi , Linus Torvalds , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: PAGE_ALIGN() compile breakage Message-Id: <20080725022547.a05ea755.akpm@linux-foundation.org> In-Reply-To: <20080725091455.GD19310@cs181140183.pp.htv.fi> References: <20080725083943.GC19310@cs181140183.pp.htv.fi> <20080725015537.564e3397.akpm@linux-foundation.org> <20080725091455.GD19310@cs181140183.pp.htv.fi> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 872 Lines: 19 On Fri, 25 Jul 2008 12:14:55 +0300 Adrian Bunk wrote: > Ideally, all headers should be self-contained. IOW, they should #include > everything they use. Yup. And the core reason for our headers mess is that the headers do too much stuff, and cnosequently demand a large dependency trail. > But TASK_UNMAPPED_BASE in asm/processor.h on some architectures uses > PAGE_ALIGN() that got moved from asm/page.h to linux/mm.h . Probably mm.h should be split up - put the simple things (usually declarations) into one "early" header file and leave the more heavyweight things (usually implementations) in mm.h. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/