Date: Fri, 25 Jul 2008 23:59:19 +0900 (JST)
Message-Id: <20080725.235919.36921137.anemo@mba.ocn.ne.jp>
To: Trond.Myklebust@netapp.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.26-git] Fix oops on remounting nfsroot
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
In-Reply-To: <1216934983.7171.1.camel@localhost>
References: <20080724.185122.139681307.nemoto@toshiba-tops.co.jp>
	<1216934983.7171.1.camel@localhost>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 826
Lines: 24

On Thu, 24 Jul 2008 14:29:43 -0700, Trond Myklebust <Trond.Myklebust@netapp.com> wrote:
> > +	if (!options ||
> > +	    (nfsvers == 4 && options4->version == 1) ||
> >  	    (nfsvers <= 3 && options->version >= 1 &&
> >  	     options->version <= 6))
> >  		return 0;
> 
> The above is almost correct. You need to test for options4 if the
> filesystem is NFSv4.

But options == options4 == raw_data ;)

> Marc Zyngier sent me a patch for the same problem a couple of days ago,
> but I have yet to pass it on to Linus.

OK, I'll wait that patch merged.  Thanks.

---
Atsushi Nemoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/