Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753944AbYGZFfR (ORCPT ); Sat, 26 Jul 2008 01:35:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751478AbYGZFfE (ORCPT ); Sat, 26 Jul 2008 01:35:04 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:42715 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751038AbYGZFfD (ORCPT ); Sat, 26 Jul 2008 01:35:03 -0400 Date: Sat, 26 Jul 2008 01:34:59 -0400 From: Christoph Hellwig To: Harvey Harrison Cc: Linus Torvalds , David Miller , Andrew Morton , LKML Subject: Re: [PATCH] byteorder: force in-place endian conversion to always evaluate args Message-ID: <20080726053459.GA26063@infradead.org> References: <1217003621.5971.4.camel@brick> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1217003621.5971.4.camel@brick> User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 650 Lines: 15 On Fri, Jul 25, 2008 at 09:33:41AM -0700, Harvey Harrison wrote: > David Miller reported breakage in ide when the in-place byteorder helpers > were used as the macros do not always evaluate their args which led to > an infinite loop. > > Just make them functions to ensure they always do so. Of course the best thing would be to kill these macros entirely. In-place endianess conversions are bad idea. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/