Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752296AbYGZI3V (ORCPT ); Sat, 26 Jul 2008 04:29:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750894AbYGZI3N (ORCPT ); Sat, 26 Jul 2008 04:29:13 -0400 Received: from az33egw01.freescale.net ([192.88.158.102]:51563 "EHLO az33egw01.freescale.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750717AbYGZI3M (ORCPT ); Sat, 26 Jul 2008 04:29:12 -0400 Date: Sat, 26 Jul 2008 01:26:01 -0700 (PDT) From: Trent Piepho X-X-Sender: xyzzy@t2.domain.actdsltmp To: Anton Vorontsov cc: Grant Likely , linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org Subject: Re: [RFC PATCH] of_gpio: implement of_get_gpio_flags() In-Reply-To: <20080725164815.GA23228@polina.dev.rtsoft.ru> Message-ID: References: <20080717234201.GA15745@polina.dev.rtsoft.ru> <20080718100549.GA28741@polina.dev.rtsoft.ru> <20080721175357.GA1773@polina.dev.rtsoft.ru> <20080723145650.GA13792@polina.dev.rtsoft.ru> <20080725164815.GA23228@polina.dev.rtsoft.ru> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 685 Lines: 15 On Fri, 25 Jul 2008, Anton Vorontsov wrote: > > The name seems a bit unfortunate though, because one could read the > function as it gets gpio flags only (though, we might implement > this instead, but this way average driver will end up with parsing > gpios = <> twice). It is kind of a confusing name. I'd be tempted to just change of_get_gpio, it's a new function and it's only called from four places so it's not that hard to change. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/