Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752680AbYGZJKT (ORCPT ); Sat, 26 Jul 2008 05:10:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751447AbYGZJKF (ORCPT ); Sat, 26 Jul 2008 05:10:05 -0400 Received: from il.qumranet.com ([212.179.150.194]:50620 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751330AbYGZJKD (ORCPT ); Sat, 26 Jul 2008 05:10:03 -0400 Message-ID: <488AE9E9.1020502@qumranet.com> Date: Sat, 26 Jul 2008 12:10:01 +0300 From: Avi Kivity User-Agent: Thunderbird 2.0.0.14 (X11/20080501) MIME-Version: 1.0 To: Julia Lawall CC: kvm@vger.kernel.org, xiantao.zhang@intel.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH retry] arch/ia64/kvm/kvm-ia64.c: Add local_irq_restore in error handling code References: In-Reply-To: Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0 (firebolt.argo.co.il [0.0.0.0]); Sat, 26 Jul 2008 12:10:01 +0300 (IDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 655 Lines: 20 Julia Lawall wrote: > From: Julia Lawall > > There is a call to local_irq_restore in the normal exit case, so it would > seem that there should be one on an error return as well. > > The semantic patch that finds this problem is as follows: > (http://www.emn.fr/x-info/coccinelle/) > Applied, thanks. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/