Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755152AbYGZJ4g (ORCPT ); Sat, 26 Jul 2008 05:56:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751786AbYGZJ42 (ORCPT ); Sat, 26 Jul 2008 05:56:28 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:46439 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751545AbYGZJ41 (ORCPT ); Sat, 26 Jul 2008 05:56:27 -0400 Date: Sat, 26 Jul 2008 11:56:12 +0200 From: Ingo Molnar To: Robert Richter Cc: Barry Kasindorf , Thomas Gleixner , oprofile-list , LKML Subject: Re: [PATCH 08/24] OProfile: Moving increment_tail() in buffer_sync.c Message-ID: <20080726095612.GD25890@elte.hu> References: <1216753748-11261-1-git-send-email-robert.richter@amd.com> <1216753748-11261-9-git-send-email-robert.richter@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1216753748-11261-9-git-send-email-robert.richter@amd.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.1 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.1 required=5.9 tests=BAYES_05 autolearn=no SpamAssassin version=3.2.3 -1.1 BAYES_05 BODY: Bayesian spam probability is 1 to 5% [score: 0.0161] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 461 Lines: 17 * Robert Richter wrote: > +static void increment_tail(struct oprofile_cpu_buffer *b) > +{ > + unsigned long new_tail = b->tail_pos + 1; > + > + rmb(); this barrier needs a comment. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/