Date: Sat, 26 Jul 2008 13:16:26 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Robert Richter <robert.richter@amd.com>
Cc: Jason Yeh <jason.yeh@amd.com>, Thomas Gleixner <tglx@linutronix.de>,
       oprofile-list <oprofile-list@lists.sourceforge.net>,
       LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Oprofile Multiplexing Patch
Message-ID: <20080726111626.GL25890@elte.hu>
References: <1216847153-28435-2-git-send-email-robert.richter@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1216847153-28435-2-git-send-email-robert.richter@amd.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 946
Lines: 24


> From: Jason Yeh <jason.yeh@amd.com>

> diff --git a/arch/x86/oprofile/op_model_p4.c b/arch/x86/oprofile/op_model_p4.c
> index 56b4757..e641545 100644
> --- a/arch/x86/oprofile/op_model_p4.c
> +++ b/arch/x86/oprofile/op_model_p4.c
> @@ -701,6 +701,8 @@ static void p4_shutdown(struct op_msrs const * const msrs)
>  struct op_x86_model_spec const op_p4_ht2_spec = {
>  	.num_counters = NUM_COUNTERS_HT2,
>  	.num_controls = NUM_CONTROLS_HT2,
> +	.num_hardware_counters = NUM_COUNTERS_HT2,
> +	.num_hardware_controls = NUM_CONTROLS_HT2,

is there any further change needed for Intel CPUs to benefit from 
multiplexing too, up to the max of 32 controls? (AFAICS it should work 
as-is, correct?)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/