Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756838AbYGZQl0 (ORCPT ); Sat, 26 Jul 2008 12:41:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752947AbYGZQlQ (ORCPT ); Sat, 26 Jul 2008 12:41:16 -0400 Received: from mailhub.sw.ru ([195.214.232.25]:7201 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751946AbYGZQlP (ORCPT ); Sat, 26 Jul 2008 12:41:15 -0400 Subject: Re: [PATCH] netns: fix ip_rt_frag_needed rt_is_expired From: "Denis V. Lunev" To: Hugh Dickins Cc: David Miller , Andrew Morton , Ingo Molnar , netdev@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: References: Content-Type: text/plain Organization: OpenVz kernel team Date: Sat, 26 Jul 2008 20:37:32 +0400 Message-Id: <1217090252.6549.4.camel@iris.sw.ru> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1422 Lines: 36 Acked-by: Denis V. Lunev Thanks for founding this issue... On Sat, 2008-07-26 at 13:48 +0100, Hugh Dickins wrote: > Running recent kernels, and using a particular vpn gateway, I've been > having to edit my mails down to get them accepted by the smtp server. > > Git bisect led to commit e84f84f276473dcc673f360e8ff3203148bdf0e2 - > netns: place rt_genid into struct net. The conversion from a != test > to rt_is_expired() put one negative too many: and now my mail works. > > Signed-off-by: Hugh Dickins > --- > Ingo was having strange distcc problems, might this help him too? > > net/ipv4/route.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- 2.6.26-git/net/ipv4/route.c 2008-07-26 12:31:50.000000000 +0100 > +++ linux/net/ipv4/route.c 2008-07-26 13:10:04.000000000 +0100 > @@ -1502,7 +1502,7 @@ unsigned short ip_rt_frag_needed(struct > rth->fl.iif != 0 || > dst_metric_locked(&rth->u.dst, RTAX_MTU) || > !net_eq(dev_net(rth->u.dst.dev), net) || > - !rt_is_expired(rth)) > + rt_is_expired(rth)) > continue; > > if (new_mtu < 68 || new_mtu >= old_mtu) { -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/