Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757431AbYGZSbQ (ORCPT ); Sat, 26 Jul 2008 14:31:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754330AbYGZSbA (ORCPT ); Sat, 26 Jul 2008 14:31:00 -0400 Received: from smtpeu1.atmel.com ([195.65.72.27]:41118 "EHLO bagnes.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752170AbYGZSbA (ORCPT ); Sat, 26 Jul 2008 14:31:00 -0400 Date: Sat, 26 Jul 2008 20:30:34 +0200 From: Haavard Skinnemoen To: Adrian Bunk Cc: Andrew Morton , Hugh Dickins , linux-kernel@vger.kernel.org Subject: Re: [2.6 patch] linux/swap.h must #include Message-ID: <20080726203034.456e7678@siona.local> In-Reply-To: <20080726173832.GE9301@cs181140183.pp.htv.fi> References: <1217092685-15267-1-git-send-email-haavard.skinnemoen@atmel.com> <20080726173832.GE9301@cs181140183.pp.htv.fi> Organization: Atmel X-Mailer: Claws Mail 3.3.1 (GTK+ 2.12.9; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 26 Jul 2008 18:30:33.0484 (UTC) FILETIME=[B09FC4C0:01C8EF4D] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 675 Lines: 19 On Sat, 26 Jul 2008 20:38:32 +0300 Adrian Bunk wrote: > The patch is not the correct fix since the actual problem comes from > free_pages_and_swap_cache() in swap.h True, but I saw this comment in swap.h: /* only sparc can not include linux/pagemap.h in this file * so leave page_cache_release and release_pages undeclared... */ so I thought it might be safer to add the include to tlb.h instead. Haavard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/