Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758012AbYGZVGN (ORCPT ); Sat, 26 Jul 2008 17:06:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757302AbYGZVF5 (ORCPT ); Sat, 26 Jul 2008 17:05:57 -0400 Received: from extu-mxob-1.symantec.com ([216.10.194.28]:47534 "EHLO extu-mxob-1.symantec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757240AbYGZVF4 (ORCPT ); Sat, 26 Jul 2008 17:05:56 -0400 Date: Sat, 26 Jul 2008 22:05:34 +0100 (BST) From: Hugh Dickins X-X-Sender: hugh@blonde.site To: Adrian Bunk cc: Andrew Morton , Haavard Skinnemoen , Yoichi Yuasa , Ben Herrenschmidt , linux-kernel@vger.kernel.org Subject: Re: [2.6 patch] linux/swap.h must #include In-Reply-To: <20080726204218.GG9301@cs181140183.pp.htv.fi> Message-ID: References: <1217092685-15267-1-git-send-email-haavard.skinnemoen@atmel.com> <20080726173832.GE9301@cs181140183.pp.htv.fi> <20080726125025.465d524b.akpm@linux-foundation.org> <20080726132610.6c583346.akpm@linux-foundation.org> <20080726204218.GG9301@cs181140183.pp.htv.fi> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1483 Lines: 38 On Sat, 26 Jul 2008, Adrian Bunk wrote: > On Sat, Jul 26, 2008 at 09:37:45PM +0100, Hugh Dickins wrote: > > > > I've trespassed on Adrian's good nature to ask him to run some builds > > on it, having demonstrated my incompetence twice already. But he may > > well have better things to do with his time. Hold on a mo, I'm just > > wrapping up the tmpfs BUG first. > > Sorry, if you wanted to know anything from me anything except whether my > patch is correct (as I already answered to Johannes it is not) I must > have missed it. > > What exactly do you want me to test? It was this one, just including pagemap.h back in exec.c again: not the best solution, but should be good for now. Please would you give it the build testing you were giving yours? Or feel free to point out that I'm wasting your and everybody's time, and just call for a straight revert of ba92a43d, that'd be fine too. Thanks, Hugh --- 2.6.26-git/fs/exec.c 2008-07-26 12:33:28.000000000 +0100 +++ linux/fs/exec.c 2008-07-26 18:50:38.000000000 +0100 @@ -32,6 +32,7 @@ #include #include #include +#include #include #include #include -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/