Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758833AbYG1AdR (ORCPT ); Sun, 27 Jul 2008 20:33:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756915AbYG1AdD (ORCPT ); Sun, 27 Jul 2008 20:33:03 -0400 Received: from chilli.pcug.org.au ([203.10.76.44]:33283 "EHLO smtps.tip.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756766AbYG1AdB (ORCPT ); Sun, 27 Jul 2008 20:33:01 -0400 Date: Mon, 28 Jul 2008 10:32:53 +1000 From: Stephen Rothwell To: Andrew Morton Cc: Benjamin Herrenschmidt , Paul Mackerras , ppc-dev , LKML , FUJITA Tomonori , Jeff Garzik Subject: Re: [PATCH] powerpc/ibmveth: fix multiple errors with dma_mapping_error conversion Message-Id: <20080728103253.5256e6c0.sfr@canb.auug.org.au> In-Reply-To: <20080727122414.cac4e336.akpm@linux-foundation.org> References: <20080728021424.40cf66bc.sfr@canb.auug.org.au> <20080727122414.cac4e336.akpm@linux-foundation.org> X-Mailer: Sylpheed 2.5.0 (GTK+ 2.12.11; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg="PGP-SHA1"; boundary="Signature=_Mon__28_Jul_2008_10_32_53_+1000_0JQ_/qAiFWNDz46v" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1658 Lines: 50 --Signature=_Mon__28_Jul_2008_10_32_53_+1000_0JQ_/qAiFWNDz46v Content-Type: text/plain; charset=US-ASCII Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Andrew, On Sun, 27 Jul 2008 12:24:14 -0700 Andrew Morton wrote: > > On Mon, 28 Jul 2008 02:14:24 +1000 Stephen Rothwell wrote: >=20 > > The addition of an argument to dma_mapping_error() in commit > > 8d8bb39b9eba32dd70e87fd5ad5c5dd4ba118e06 "dma-mapping: add the device > > argument to dma_mapping_error()" left a bit of fallout: >=20 > Yeah, sorry, that patch was a horror - I fixed it perhaps ten times. I > think people were madly adding new dma_mapping_error() calls while we > were trying to maintain it as well. >=20 > It should have been dome as a two-stage conversion. Yes, indeed (my new favourite word :-)) I hope that we all can discuss procedures for API changes at the Kernel Summit ... --=20 Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ --Signature=_Mon__28_Jul_2008_10_32_53_+1000_0JQ_/qAiFWNDz46v Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkiNE7UACgkQjjKRsyhoI8zTcgCePJJdfrTRzlwHIQkh2vwNv3Ax AxUAn0VftUIy32jvnG+ULTZqvOc6dmi8 =9/z9 -----END PGP SIGNATURE----- --Signature=_Mon__28_Jul_2008_10_32_53_+1000_0JQ_/qAiFWNDz46v-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/