Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759052AbYG1CGw (ORCPT ); Sun, 27 Jul 2008 22:06:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751710AbYG1CGo (ORCPT ); Sun, 27 Jul 2008 22:06:44 -0400 Received: from az33egw01.freescale.net ([192.88.158.102]:63330 "EHLO az33egw01.freescale.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752372AbYG1CGn (ORCPT ); Sun, 27 Jul 2008 22:06:43 -0400 From: Trent Piepho To: Stephen Rothwell Cc: Grant Likely , linux-kernel@vger.kernel.org, Anton Vorontsov , Richard Purdie , Kumar Gala , linuxppc-dev@ozlabs.org, Trent Piepho Subject: [PATCH v2] leds: make the default trigger name const Date: Sun, 27 Jul 2008 19:02:21 -0700 Message-Id: <1217210541-7641-1-git-send-email-tpiepho@freescale.com> X-Mailer: git-send-email 1.5.4.1 In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1606 Lines: 45 The default_trigger fields of struct gpio_led and thus struct led_classdev are pretty much always assigned from a string literal, which means the string can't be modified. Which is fine, since there is no reason to modify the string and in fact it never is. But they should be marked const to prevent such code from being added, to prevent warnings if -Wwrite-strings is used and when assigned from a constant string other than a string literal (which produces a warning under current kernel compiler flags), and for general good coding practices. Signed-off-by: Trent Piepho --- include/linux/leds.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/leds.h b/include/linux/leds.h index 519df72..defe693 100644 --- a/include/linux/leds.h +++ b/include/linux/leds.h @@ -48,7 +48,7 @@ struct led_classdev { struct device *dev; struct list_head node; /* LED Device list */ - char *default_trigger; /* Trigger to use */ + const char *default_trigger; /* Trigger to use */ #ifdef CONFIG_LEDS_TRIGGERS /* Protects the trigger data below */ @@ -121,7 +121,7 @@ extern void ledtrig_ide_activity(void); /* For the leds-gpio driver */ struct gpio_led { const char *name; - char *default_trigger; + const char *default_trigger; unsigned gpio; u8 active_low; }; -- 1.5.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/