Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754822AbYG1JxT (ORCPT ); Mon, 28 Jul 2008 05:53:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750728AbYG1JxM (ORCPT ); Mon, 28 Jul 2008 05:53:12 -0400 Received: from rtsoft3.corbina.net ([85.21.88.6]:12082 "EHLO buildserver.ru.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752053AbYG1JxL (ORCPT ); Mon, 28 Jul 2008 05:53:11 -0400 Date: Mon, 28 Jul 2008 13:53:09 +0400 From: Anton Vorontsov To: Trent Piepho Cc: Stephen Rothwell , Grant Likely , linux-kernel@vger.kernel.org, Richard Purdie , Kumar Gala , linuxppc-dev@ozlabs.org Subject: Re: [PATCH 1/2] leds: make the default trigger name const Message-ID: <20080728095309.GA31809@polina.dev.rtsoft.ru> Reply-To: avorontsov@ru.mvista.com References: <1217019705-24244-1-git-send-email-tpiepho@freescale.com> <20080727020857.GM12191@secretlab.ca> <20080727231149.1b2508da.sfr@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1891 Lines: 38 On Sun, Jul 27, 2008 at 06:56:49PM -0700, Trent Piepho wrote: > On Sun, 27 Jul 2008, Stephen Rothwell wrote: > > On Sat, 26 Jul 2008 20:08:57 -0600 Grant Likely wrote: > >> On Fri, Jul 25, 2008 at 02:01:44PM -0700, Trent Piepho wrote: > >>> The default_trigger fields of struct gpio_led and thus struct led_classdev > >>> are pretty much always assigned from a string literal, which means the > >>> string can't be modified. Which is fine, since there is no reason to > >>> modify the string and in fact it never is. > >>> > >>> But they should be marked const to prevent such code from being added, to > >>> prevent warnings if -Wwrite-strings is used and when assigned from a > >>> constant string other than a string literal (which produces a warning under > >>> current kernel compiler flags), and for general good coding practices. > >>> > >>> Signed-off-by: Trent Piepho > >> Acked-by: Grant Likely > > > > I would ack this as well, except I am not sure what tree this patch is > > against. In the current powerpc next tree, > > It was against powerpc next from Jul 22nd, current at the time I made the > patch. It looks like that file has changed in the last few days. There is a > patch from Anton Vorontsov, "leds: mark led_classdev.default_trigger as > const", which adds const to one of the structs I modified, but doesn't get the > other one (struct gpio_led). Yes, I posted the patch for my version of OF GPIO LEDs, which didn't use struct gpio_led's default_trigger. -- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/