Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758861AbYG1S6R (ORCPT ); Mon, 28 Jul 2008 14:58:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755858AbYG1S6G (ORCPT ); Mon, 28 Jul 2008 14:58:06 -0400 Received: from astoria.ccjclearline.com ([64.235.106.9]:34419 "EHLO astoria.ccjclearline.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755074AbYG1S6E (ORCPT ); Mon, 28 Jul 2008 14:58:04 -0400 Date: Mon, 28 Jul 2008 14:56:27 -0400 (EDT) From: "Robert P. J. Day" X-X-Sender: rpjday@localhost.localdomain To: Randy Dunlap cc: Calvin Walton , Linux Kernel Mailing List , Andrew Morton Subject: Re: [PATCH] FILESYSTEMS: Make "advanced partitions" immediately unselectable. In-Reply-To: <20080728115112.282f3585.randy.dunlap@oracle.com> Message-ID: References: <20080726094718.b617c1e7.randy.dunlap@oracle.com> <1217214689.22927.3.camel@zem.phub.net.cable.rogers.com> <20080728103731.7bafd577.randy.dunlap@oracle.com> <20080728115112.282f3585.randy.dunlap@oracle.com> User-Agent: Alpine 1.10 (LFD 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - astoria.ccjclearline.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - crashcourse.ca X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1797 Lines: 50 On Mon, 28 Jul 2008, Randy Dunlap wrote: > On Mon, 28 Jul 2008 14:42:47 -0400 (EDT) Robert P. J. Day wrote: > > > On Mon, 28 Jul 2008, Randy Dunlap wrote: > > > > > > yes, it's nitpicking but, as it's laid out right now, it's > > > > unnecessarily confusing and inconsistent. but i don't know if > > > > there's a trivial fix for it. > > > > > > Yes, I'd call MSDOS partitions basic, not Advanced, and then put all > > > others under an Advanced menu that can be toggled on/off easily with > > > menuconfig. > > > > > > Not quite trivial, but not messy either. > > > > > > Patch below. Comments? > > > > ... patch snipped ... > > > > i suspect that's as good as it's going to get, but it's > > unfortunate that it adds yet another level of submenu under > > "Partition types." > > I looked but didn't see a way to avoid that. upon further consideration, i don't either, so i'm happy with it. the only thing i might add is some actual help text for that MSDOS_PARTITION option -- something more informative than "Say Y here." perhaps a sentence explaining *why* people might want to say "Y" there? or the rare circumstances under which they wouldn't? just a thought. other than that, it looks good. rday -- ======================================================================== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry: Have classroom, will lecture. http://crashcourse.ca Waterloo, Ontario, CANADA ======================================================================== -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/