Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757315AbYG1TIs (ORCPT ); Mon, 28 Jul 2008 15:08:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752033AbYG1TI1 (ORCPT ); Mon, 28 Jul 2008 15:08:27 -0400 Received: from mta23.gyao.ne.jp ([125.63.38.249]:53417 "EHLO mx.gate01.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751863AbYG1TI0 (ORCPT ); Mon, 28 Jul 2008 15:08:26 -0400 Date: Tue, 29 Jul 2008 04:07:49 +0900 From: Paul Mundt To: OGAWA Hirofumi Cc: Yoshinori Sato , Andrew Morton , lkml Subject: Re: [PATCH] filldir write data missing size Message-ID: <20080728190749.GA20019@linux-sh.org> Mail-Followup-To: Paul Mundt , OGAWA Hirofumi , Yoshinori Sato , Andrew Morton , lkml References: <87k5fi4l49.wl%ysato@users.sourceforge.jp> <871w1pn5wz.fsf@devron.myhome.or.jp> <87iqv1wwy1.wl%ysato@users.sourceforge.jp> <87r69pk51q.fsf@devron.myhome.or.jp> <87abgbgrvt.wl%ysato@users.sourceforge.jp> <878wvu9b6n.fsf@devron.myhome.or.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <878wvu9b6n.fsf@devron.myhome.or.jp> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 919 Lines: 26 On Tue, Jul 22, 2008 at 06:31:12AM +0900, OGAWA Hirofumi wrote: > Yoshinori Sato writes: > > > This problem is sh-linux-gcc v4.1.2 and target sh2(a)-bigendian. > > > > "__put_user(s64, u32_ptr)" compiled. > > > > Correct code. > > *u32_ptr = s64 & 0xffffffff; > > > > Bad code. > > *u32_ptr = s64 >> 32; > > > > I'm add cast put_user 4byte case. > > I see. How about the following patch? I guess the problems of this type > should be fixed. > I merged a different workaround as no one bothered to CC me on this thread. Your fix looks more correct though, please provide a Signed-off-by for it and I'll take this over the previous workaround. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/