Subject: Re: warning in scheduler
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Reply-To: benh@kernel.crashing.org
To: Matthew Wilcox <matthew@wil.cx>
Cc: Ingo Molnar <mingo@elte.hu>, Peter Zijlstra <peterz@infradead.org>,
       "H. Peter Anvin" <hpa@zytor.com>,
       Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org,
       stephen@blacksapphire.com, benm@symmetric.co.nz, jkosina@suse.cz
In-Reply-To: <20080728183911.GC16059@parisc-linux.org>
References: <1217214947.11188.156.camel@pasglop>
	 <1217238791.6331.15.camel@twins> <1217239403.11188.189.camel@pasglop>
	 <20080728100752.GA4717@elte.hu> <1217241622.11188.191.camel@pasglop>
	 <20080728183911.GC16059@parisc-linux.org>
Content-Type: text/plain
Date: Tue, 29 Jul 2008 07:19:16 +1000
Message-Id: <1217279956.11188.221.camel@pasglop>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1824
Lines: 47

On Mon, 2008-07-28 at 12:39 -0600, Matthew Wilcox wrote:
> On Mon, Jul 28, 2008 at 08:40:22PM +1000, Benjamin Herrenschmidt wrote:
> > I tend to agree. I might look into doing it for powerpc around rc3 or
> > so, when things have settled a bit.
> 
> It'd be nice if allmodconfig even compiled:
> 
> drivers/char/pcmcia/ipwireless/hardware.c:571: error: invalid use of undefined type 'struct ipw_network'
> 
> Not to mention the qla_attr patch:
> 
> +#include <linux/delay.h>
> 
> There's probably others, I just haven't got far enough in the
> compilation process yet.

Yup, it's been a pretty bad merge window (at least it's my impression as
my first one as maintainer), mostly fixing compile bugs all the time.

> But I am seeing lots of warnings _without_ the patch applied:
> 
> fs/omfs/inode.c: In function 'omfs_fill_super':
> fs/omfs/inode.c:495: warning: format '%llx' expects type 'long long
> unsigned int', but argument 2 has type 'u64'
> fs/proc/base.c: In function 'do_io_accounting':
> fs/proc/base.c:2429: warning: format '%llu' expects type 'long long
> unsigned int', but argument 3 has type 'u64'
> fs/ubifs/dir.c: In function 'ubifs_readdir':
> fs/ubifs/dir.c:437: warning: format '%llu' expects type 'long long
> unsigned int', but argument 5 has type '__le64'
> 
> (other warnings snipped for brevity).

I have a handful on powerpc too.

BTW. I'm looking at adding a %pR to print a struct resource (or maybe
a %pr for a resource_size_t and %pR for the whole resource). That would
help with the whole business of the thing being either 32 or 64 bits.

Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/