DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=yahoo.com.au;
  h=Received:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id;
  b=Umji3d2leAXTN3WrC1OvZoHAJMnISIMi7RL+W1EBrvg6HysvKM8FmMYEsA+DwwCc8FpITvMiQijmXoqbUkJGvKXs+4hBDPI/IKuiQMhvpFDa3u+cpyGWDY0Xf55Ec0MewIA7/3M59UfAQbPwzXdG2bEJJZ912eRuNONu4cgAOQA=  ;
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Linus Torvalds <torvalds@linux-foundation.org>, benh@kernel.crashing.org
Subject: Re: [PATCH] x86: do not overrun page table ranges in gup
Date: Tue, 29 Jul 2008 11:37:19 +1000
User-Agent: KMail/1.9.5
Cc: Johannes Weiner <hannes@saeurebad.de>,
       Alexey Dobriyan <adobriyan@gmail.com>, akpm@linuxfoundation.org,
       torvalds@linuxfoundation.org, npiggin@suse.de,
       linux-kernel@vger.kernel.org
References: <20080728184947.GA5041@martell.zuzino.mipt.ru> <alpine.LFD.1.10.0807281721200.3486@nehalem.linux-foundation.org> <alpine.LFD.1.10.0807281737480.3486@nehalem.linux-foundation.org>
In-Reply-To: <alpine.LFD.1.10.0807281737480.3486@nehalem.linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200807291137.20259.nickpiggin@yahoo.com.au>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 762
Lines: 19

On Tuesday 29 July 2008 10:39, Linus Torvalds wrote:
> On Mon, 28 Jul 2008, Linus Torvalds wrote:
> > So no, the right fix would be to align 'start' first, which means that
> > everything else (including 'end') will be page-aligned. Aligning just one
> > or the other is very very wrong.
>
> Does this work?
>
> Not pretty, but it stands _some_ chance of being correct.

No, that's not particularly ugly and I think the fix is good. Thank you
everyone involved in the thread.

Acked-by: Nick Piggin <npiggin@suse.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/