Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756140AbYG2CWT (ORCPT ); Mon, 28 Jul 2008 22:22:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751739AbYG2CWF (ORCPT ); Mon, 28 Jul 2008 22:22:05 -0400 Received: from SpacedOut.fries.net ([67.64.210.234]:50113 "EHLO SpacedOut.fries.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751375AbYG2CWD (ORCPT ); Mon, 28 Jul 2008 22:22:03 -0400 Date: Mon, 28 Jul 2008 21:21:57 -0500 From: David Fries To: Andrew Morton Cc: linux-kernel@vger.kernel.org, Evgeniy Polyakov Subject: [PATCH 13/30] W1: w1_family, remove unused variable need_exit Message-ID: <20080729022157.GM24452@spacedout.fries.net> References: <20080729020433.GA24424@spacedout.fries.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="/jvaajy/zP2g41+Q" Content-Disposition: inline In-Reply-To: <20080729020433.GA24424@spacedout.fries.net> User-Agent: Mutt/1.5.4i X-Greylist: Sender is SPF-compliant, not delayed by milter-greylist-3.0 (SpacedOut.fries.net [127.0.0.1]); Mon, 28 Jul 2008 21:21:57 -0500 (CDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2201 Lines: 82 --/jvaajy/zP2g41+Q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Removed the w1_family structure member variable need_exit. It was only being set and never used. Even if it were to be used it is a polling type operation. Signed-off-by: David Fries Signed-off-by: Evgeniy Polyakov --- drivers/w1/w1_family.c | 7 +------ drivers/w1/w1_family.h | 1 - 2 files changed, 1 insertions(+), 7 deletions(-) diff --git a/drivers/w1/w1_family.c b/drivers/w1/w1_family.c index 8c35f9c..4a09904 100644 --- a/drivers/w1/w1_family.c +++ b/drivers/w1/w1_family.c @@ -48,7 +48,6 @@ int w1_register_family(struct w1_family *newf) =20 if (!ret) { atomic_set(&newf->refcnt, 0); - newf->need_exit =3D 0; list_add_tail(&newf->family_entry, &w1_families); } spin_unlock(&w1_flock); @@ -73,9 +72,6 @@ void w1_unregister_family(struct w1_family *fent) break; } } - - fent->need_exit =3D 1; - spin_unlock(&w1_flock); =20 /* deatch devices using this family code */ @@ -113,8 +109,7 @@ struct w1_family * w1_family_registered(u8 fid) =20 static void __w1_family_put(struct w1_family *f) { - if (atomic_dec_and_test(&f->refcnt)) - f->need_exit =3D 1; + atomic_dec(&f->refcnt); } =20 void w1_family_put(struct w1_family *f) diff --git a/drivers/w1/w1_family.h b/drivers/w1/w1_family.h index 296a87e..3053133 100644 --- a/drivers/w1/w1_family.h +++ b/drivers/w1/w1_family.h @@ -53,7 +53,6 @@ struct w1_family struct w1_family_ops *fops; =20 atomic_t refcnt; - u8 need_exit; }; =20 extern spinlock_t w1_flock; --=20 1.4.4.4 --/jvaajy/zP2g41+Q Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (GNU/Linux) iD8DBQFIjn7FAI852cse6PARAkGcAJ9EOoMtSbgSKGT20LLHsxYkPtIh1wCaAlMl 7E7vKWu938gQcpVzB256S+Y= =MyPU -----END PGP SIGNATURE----- --/jvaajy/zP2g41+Q-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/