Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755147AbYG2IB0 (ORCPT ); Tue, 29 Jul 2008 04:01:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753038AbYG2IBR (ORCPT ); Tue, 29 Jul 2008 04:01:17 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:33064 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752688AbYG2IBQ (ORCPT ); Tue, 29 Jul 2008 04:01:16 -0400 Date: Tue, 29 Jul 2008 10:00:55 +0200 From: Ingo Molnar To: Stephen Rothwell Cc: David Miller , linux-next@vger.kernel.org, LKML , Andrew Morton , Linus , Mike Travis Subject: Re: linux-next: build failure Message-ID: <20080729080055.GA28916@elte.hu> References: <20080729162300.733b3e09.sfr@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080729162300.733b3e09.sfr@canb.auug.org.au> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1800 Lines: 48 * Stephen Rothwell wrote: > Hi Dave, > > Today's linux-next build (sparc64 defconfig) failed like this: > > kernel/time/tick-common.c: In function `tick_check_new_device': > kernel/time/tick-common.c:210: error: invalid lvalue in unary `&' > kernel/time/tick-common.c:223: error: invalid lvalue in unary `&' > kernel/time/tick-common.c:255: error: invalid lvalue in unary `&' > > gcc is version 3.4.5 sparc64 cross compiler (powercp64 host). > > The below patch fixes it. > > when you take the address of the result. Noticed on a sparc64 compile > using a version 3.4.5 cross compiler. > > kernel/time/tick-common.c: In function `tick_check_new_device': > kernel/time/tick-common.c:210: error: invalid lvalue in unary `&' > kernel/time/tick-common.c:223: error: invalid lvalue in unary `&' > kernel/time/tick-common.c:255: error: invalid lvalue in unary `&' > > Signed-off-by: Stephen Rothwell > --- > include/linux/cpumask.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/linux/cpumask.h b/include/linux/cpumask.h > index 96d0509..d3219d7 100644 > --- a/include/linux/cpumask.h > +++ b/include/linux/cpumask.h > @@ -287,7 +287,7 @@ static inline const cpumask_t *get_cpu_mask(unsigned int cpu) > * gcc optimizes it out (it's a constant) and there's no huge stack > * variable created: > */ > -#define cpumask_of_cpu(cpu) ({ *get_cpu_mask(cpu); }) > +#define cpumask_of_cpu(cpu) (*get_cpu_mask(cpu)) hm, i'm wondering - is this a compiler bug? Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/