Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754924AbYG2IJ2 (ORCPT ); Tue, 29 Jul 2008 04:09:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755686AbYG2II5 (ORCPT ); Tue, 29 Jul 2008 04:08:57 -0400 Received: from mtagate8.de.ibm.com ([195.212.29.157]:12772 "EHLO mtagate8.de.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754361AbYG2IIy (ORCPT ); Tue, 29 Jul 2008 04:08:54 -0400 Subject: Re: [patch 01/15] kmsg: Kernel message catalog macros. From: Martin Schwidefsky Reply-To: schwidefsky@de.ibm.com To: Joe Perches Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, Michael Holzheu In-Reply-To: <1217268724.9355.14.camel@localhost> References: <20080728175355.734299984@de.ibm.com> <20080728175511.023246676@de.ibm.com> <1217268724.9355.14.camel@localhost> Content-Type: text/plain Organization: IBM Corporation Date: Tue, 29 Jul 2008 10:07:32 +0200 Message-Id: <1217318852.10259.1.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 765 Lines: 23 On Mon, 2008-07-28 at 11:12 -0700, Joe Perches wrote: > On Mon, 2008-07-28 at 19:53 +0200, Martin Schwidefsky wrote: > > The kmsg component name is defined per source file with the KMSG_COMPONENT > > macro. > > Why not use KBUILD_MODNAME? Because sometimes we might want to use the same kmsg prefix for multiple modules. And the message tag is supposed to stay the same even if the code structure changes. I'd rather not use KBUILD_MODNAME. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/