Subject: Re: [patch 02/15] kmsg: Kernel message catalog script.
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
Reply-To: schwidefsky@de.ibm.com
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
       Michael Holzheu <holzheu@de.ibm.com>
In-Reply-To: <20080728192828.GA11431@uranus.ravnborg.org>
References: <20080728175355.734299984@de.ibm.com>
	 <20080728175511.260174666@de.ibm.com>
	 <20080728192828.GA11431@uranus.ravnborg.org>
Content-Type: text/plain
Organization: IBM Corporation
Date: Tue, 29 Jul 2008 10:42:30 +0200
Message-Id: <1217320950.10259.15.camel@localhost>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1817
Lines: 56

On Mon, 2008-07-28 at 21:28 +0200, Sam Ravnborg wrote:
> > 
> > The kmsg man page creation is invoked with "make K=2" and reads the source
> > files for all built objects, looks up the message description and writes
> > a man page to $(objtree)/man.
> Can we use M=2 instead of K=?
> I have sort of reserved 'K' for Kconfig usage.

Ok, K= is taken but I can't use M= either because that is used for KBUILD_EXTMOD.
If tested with D= for "documentation", would that be okay ?

> > @@ -339,6 +341,19 @@ $(multi-used-m) : %.o: $(multi-objs-m) F
> >  
> >  targets += $(multi-used-y) $(multi-used-m)
> >  
> > +# kmsg check tool
> > +ifneq ($(KBUILD_KMSG_CHECK),0)
> > +  ifeq ($(KBUILD_KMSG_CHECK),2)
> > +    kmsg_cmd = print
> > +    quiet_cmd_force_check_kmsg = KMSG_PRINT $<
> > +    $(shell [ -d $(objtree)/man ] || mkdir -p $(objtree)/man)
> > +  else
> > +    kmsg_cmd = check
> > +    quiet_cmd_force_check_kmsg = KMSG_CHECK $<
> > +  endif
> > +  cmd_force_check_kmsg = SRCTREE=$(srctree) OBJTREE=$(objtree) \
> > +			$(KMSG_CHECK) $(kmsg_cmd) $(CC) $(c_flags) $< ;
> > +endif
> We are executing with $(objtree) as current directory so no need
> to specify $(objtree) in the above.

Ok, dropped $(objtree) from the shell command.

> You can used non-recursive assignments for kmsg_cmd (use ':=').

Will do.

> Do you really need the uppercase SRCTREE, OBJTREE?
> Other scripts uses the lower cases variants direct.

Ok, I'll fix the script to use srctree and objtree directly.

Thanks Sam.

-- 
blue skies,
  Martin.

"Reality continues to ruin my life." - Calvin.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/