Date: Wed, 30 Jul 2008 00:26:22 +0100
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "David Wilson" <mcs6502@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: pci_ids.h - duplicate entry and many out of order definitions
Message-ID: <20080730002622.47bd7569@lxorguk.ukuu.org.uk>
In-Reply-To: <3666888f0807291600n3c259c20wccc4896b2df3d0d8@mail.gmail.com>
References: <3666888f0807291600n3c259c20wccc4896b2df3d0d8@mail.gmail.com>
Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street,
 Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a
 Lloegr o'r rhif cofrestru 3798903
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1151
Lines: 25

On Wed, 30 Jul 2008 09:00:09 +1000
"David Wilson" <mcs6502@gmail.com> wrote:

> I was browsing the pci_ids.h file and came across a duplicate entry
> for PCI_VENDOR_ID_RDC. This prompted me to look further and I found a
> number of out-of-order definitions (based on the comment at the head
> of the file that indicates that they should be sorted). I decided to
> write a script to check this and it found 74 "errors".
> 
> 1) Is it worth my time generating a patch to fix all these mis-orderings?
> 2) Should it be one large patch or many small ones (eg one per PCI_VENDOR)?
> 3) Is there a maintainer for this file?

1. Yes
2. It depends how big the patch is. I like the idea of one per vendor
sorting the vendor device entries into order and one then putting the
vendors in order. That would be easy to check/read
3. jbarnes@virtuousgeek.org

(in theory. I don' t know if he thinks its his file yet ;))
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/