Message-ID: <488FCC14.3070208@openvz.org>
Date: Wed, 30 Jul 2008 06:04:04 +0400
From: Pavel Emelyanov <xemul@openvz.org>
User-Agent: Thunderbird 2.0.0.14 (X11/20080501)
MIME-Version: 1.0
To: David Howells <dhowells@redhat.com>
CC: Oleg Nesterov <oleg@tv-sign.ru>, jmorris@redhat.com,
       linux-kernel@vger.kernel.org
Subject: Re: Request for documentation of PID handling functions
References: <21590.1217285986@redhat.com>
In-Reply-To: <21590.1217285986@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1063
Lines: 34

David Howells wrote:
> Hi Pavel,
> 
> Can you please provide documentation for the PID handling functions you
> supplied in commit:
> 
> 	7af5729474b5b8ad385adadab78d6e723e7655a3
> 
> In particular I'd like to know what locks are required when.  I'm trying to
> determine if in this piece of code:
> 
> 		read_lock(&tasklist_lock);
> 		ret = 0;
> 		if (pid != task_pid_vnr(current))
> 			ret = -EPERM;
> 		read_unlock(&tasklist_lock);
> 
> the lock of tasklist_lock is necessary.

The RCU protection is enough to get pids from tasks. However, the pids
are detached under the tasklist lock write-locked, so provided you're
*already* sitting under it the RCU is excessive.

However, Oleg pointed me out some time ago, that in some cases RCU-only
protection was not enough in some cases, so I put him in Cc.

> David
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/