Date: Wed, 30 Jul 2008 13:10:03 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Mikael Pettersson <mikpe@it.uu.se>
Cc: hpa@zytor.com, mingo@redhat.com, tglx@linutronix.de,
       linux-kernel@vger.kernel.org
Subject: Re: [BUG] x86: 2.6.27-rc1 does not build with gcc-3.2.3 any more
Message-ID: <20080730111003.GA23933@elte.hu>
References: <200807301102.m6UB2AiI022512@harpo.it.uu.se>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200807301102.m6UB2AiI022512@harpo.it.uu.se>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1285
Lines: 37


* Mikael Pettersson <mikpe@it.uu.se> wrote:

> static inline __attribute__((always_inline))
> unsigned char readb(const volatile void *addr)
> {
> 	unsigned char ret;
> 	asm volatile("mov" "b" " %1,%0"
> 		     : "=" "q" (ret)
> 		     : "m" (*(volatile unsigned char *)addr)
> 		     : "memory");
> 	return ret;
> }
> 
> The problem is that "=q" has been broken up into two adjacent
> string literals, and apparently gcc-3.2.3 hasn't done string
> literal concatenation at the time it processes the asm().
> Hence the syntax error. (This is clearly a gcc bug.)
> 
> Switching to gcc-3.3.6 or newer fixes the problem.
> 
> The question is, should the kernel be fixed to compile with 3.2.3
> again (by generating "=q" not "=" "q"), or should the minimum supported
> gcc version be bumped to 3.3.6?
> 
> I have no strong feeling about this, except that I want to use the
> oldest (== least bloated) gcc possible on my 486 test box.

yeah, please send a fix. We could move the '=' from build_mmio_read into 
the argument (explicitly).

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/