Message-ID: <48907C9E.3050301@linux-foundation.org>
Date: Wed, 30 Jul 2008 09:37:18 -0500
From: Christoph Lameter <cl@linux-foundation.org>
User-Agent: Thunderbird 2.0.0.14 (Windows/20080421)
MIME-Version: 1.0
To: =?ISO-8859-1?Q?Fernando_Luis_V=E1zquez_Cao?= 
	<fernando@oss.ntt.co.jp>
CC: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] madvise: update function comment of madvise_dontneed
References: <1217243241.3087.6.camel@sebastian.kern.oss.ntt.co.jp>
In-Reply-To: <1217243241.3087.6.camel@sebastian.kern.oss.ntt.co.jp>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1504
Lines: 30

Fernando Luis V?zquez Cao wrote:
> Signed-off-by: Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp>
> ---
> 
> diff -urNp linux-2.6.26/mm/madvise.c linux-2.6.26-fixes/mm/madvise.c
> --- linux-2.6.26/mm/madvise.c	2008-07-14 06:51:29.000000000 +0900
> +++ linux-2.6.26-fixes/mm/madvise.c	2008-07-28 19:53:27.000000000 +0900
> @@ -132,10 +132,10 @@ static long madvise_willneed(struct vm_a
>   * Application no longer needs these pages.  If the pages are dirty,
>   * it's OK to just throw them away.  The app will be more careful about
>   * data it wants to keep.  Be sure to free swap resources too.  The
> - * zap_page_range call sets things up for refill_inactive to actually free
> + * zap_page_range call sets things up for shrink_active_list to actually free
>   * these pages later if no one else has touched them in the meantime,
>   * although we could add these pages to a global reuse list for
> - * refill_inactive to pick up before reclaiming other pages.
> + * shrink_active_list to pick up before reclaiming other pages.
>   *
>   * NB: This interface discards data rather than pushes it out to swap,
>   * as some implementations do.  This has performance implications for
> 
> 

Well shrink_page_list actually does the freeing of the pages.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/