Date: Wed, 30 Jul 2008 08:45:08 -0700
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Tim Wright <timw@splhi.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
       linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] Fix miscalculation of sg_io timeout in
 CDROM_SEND_PACKET handler.
Message-Id: <20080730084508.ce14b30b.randy.dunlap@oracle.com>
In-Reply-To: <48908C27.2060308@splhi.com>
References: <488D17DE.5000801@splhi.com>
	<1217431134.3335.15.camel@localhost.localdomain>
	<48908C27.2060308@splhi.com>
Organization: Oracle Linux Eng.
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1776
Lines: 49

On Wed, 30 Jul 2008 08:43:35 -0700 Tim Wright wrote:

> James Bottomley wrote:
> > On Sun, 2008-07-27 at 17:50 -0700, Tim Wright wrote:
> >   
> >> @@ -629,7 +629,7 @@ int scsi_cmd_ioctl(struct file *file, st
> >>                         hdr.sbp = cgc.sense;
> >>                         if (hdr.sbp)
> >>                                 hdr.mx_sb_len = sizeof(struct 
> >> request_sense);
> >> -                       hdr.timeout = cgc.timeout;
> >> +                       hdr.timeout = jiffies_to_msecs(cgc.timeout);
> >>                         hdr.cmdp = ((struct cdrom_generic_command 
> >> __user*) arg)->cmd;
> >>                         hdr.cmd_len = sizeof(cgc.cmd);
> >>     
> >
> > I'm afraid this patch is completely whitespace damaged:  the tabs have
> > all become spaces and the mailer has broken some of the lines.
> >
> > Since it's a one liner, I can make the fix directly, but if you look at
> >
> > Documentation/SubmittingPatches
> >
> > It has some good advice about how to fix your email tool to prevent this
> > from happening in future.
> >
> > James
> >
> >
> >   
> Ugh, mea culpa! Thanks James. I haven't submitted anything in a while, 
> and was using Thunderbird. I will
> go off and figure out how to make it leave the contents alone, or I'll 
> use a less "clever" client in future.
> Many thanks for the response and the gentle coaching :-)

also see Documentation/email-clients.txt


---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/