Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757967AbYG3SuR (ORCPT ); Wed, 30 Jul 2008 14:50:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751688AbYG3SuE (ORCPT ); Wed, 30 Jul 2008 14:50:04 -0400 Received: from testure.choralone.org ([194.9.77.134]:38779 "EHLO testure.choralone.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750969AbYG3SuD (ORCPT ); Wed, 30 Jul 2008 14:50:03 -0400 Date: Wed, 30 Jul 2008 14:50:03 -0400 From: Dave Jones To: Mike Travis Cc: Ingo Molnar , Rusty Russell , Andrew Morton , "H. Peter Anvin" , Jack Steiner , Christoph Lameter , linux-kernel@vger.kernel.org, Len Brown , Lennert Buytenhek , Paul Jackson , Tony Luck , Tigran Aivazian , Paul Mackerras , Benjamin Herrenschmidt , Robert Richter , Martin Schwidefsky , Heiko Carstens , Sam Creasey , Greg Banks , "Eric W. Biederman" , Adrian Bunk , Thomas Gleixner , Andreas Schwab , Johannes Weiner Subject: Re: [PATCH 1/1] cpumask: Change cpumask_of_cpu to use cpumask_of_cpu_map Message-ID: <20080730185003.GA18162@codemonkey.org.uk> Mail-Followup-To: Dave Jones , Mike Travis , Ingo Molnar , Rusty Russell , Andrew Morton , "H. Peter Anvin" , Jack Steiner , Christoph Lameter , linux-kernel@vger.kernel.org, Len Brown , Lennert Buytenhek , Paul Jackson , Tony Luck , Tigran Aivazian , Paul Mackerras , Benjamin Herrenschmidt , Robert Richter , Martin Schwidefsky , Heiko Carstens , Sam Creasey , Greg Banks , "Eric W. Biederman" , Adrian Bunk , Thomas Gleixner , Andreas Schwab , Johannes Weiner References: <20080723171841.815234000@polaris-admin.engr.sgi.com> <20080723171841.997896000@polaris-admin.engr.sgi.com> <20080730165539.GA10079@codemonkey.org.uk> <4890A0A8.4000502@sgi.com> <4890B500.7040100@sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4890B500.7040100@sgi.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1388 Lines: 35 On Wed, Jul 30, 2008 at 11:37:52AM -0700, Mike Travis wrote: > >> I've lost the plot on what's going on with these cpumask patches. > >> But I just saw this on -rc1. > >> > >> arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c:206:33: error: not addressable > >> arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c:274:32: error: not addressable > >> arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c:352:34: error: not addressable > >> > > After I recreated linux-next the changes all appear to be there now. > One problem though, is !SMP config does not build (something about > DECLARE_BITMAP with NR_CPUS=1.) I wasn't sure how to create a constant > "(cpumask_t)1" that worked as an lvalue, so the following patch is > somewhat a kluge, but fulfills the requirements. > > If anyone has a better suggestion, please let me know. > > Subject: [PATCH] cpmask: add cpumask_of_cpu(0) for non-SMP > > * Fix cpumask_of_cpu(0) when CONFIG_SMP is not set by providing a > pointer to a cpumask_t with cpu 0 bit set. confused. I saw the error above with a make allyesconfig, which sets CONFIG_SMP=y Dave -- http://www.codemonkey.org.uk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/