Subject: Re: [PATCH] mISDN cleanup user interface
From: David Woodhouse <dwmw2@infradead.org>
To: Karsten Keil <kkeil@suse.de>
Cc: isdn4linux@listserv.isdn4linux.de, Marcel Holtmann <marcel@holtmann.org>,
       Linus Torvalds <torvalds@linux-foundation.org>,
       linux-kernel@vger.kernel.org
In-Reply-To: <20080730175138.GA12800@pingi.kke.suse.de>
References: <20080729195637.GB25929@pingi.kke.suse.de>
	 <1217362946.27925.137.camel@pmac.infradead.org>
	 <1217365330.417.8.camel@californication>
	 <1217409211.27925.177.camel@pmac.infradead.org>
	 <20080730163314.GB9491@pingi.kke.suse.de>
	 <1217437021.3454.8.camel@pmac.infradead.org>
	 <20080730175138.GA12800@pingi.kke.suse.de>
Content-Type: text/plain
Date: Wed, 30 Jul 2008 20:08:12 +0100
Message-Id: <1217444892.3454.28.camel@pmac.infradead.org>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 794
Lines: 19

On Wed, 2008-07-30 at 19:51 +0200, Karsten Keil wrote:
> > Are you later intending to use the bitmap to mark them as busy/free?
> 
> Yes exactely, and this was the reason why the original code (which used one u_long
> only as channelmap) already used the bit operators, since for a channel allocator
> you should be atomic, but since we are now allow 127 channels we need proper
> locking for the busy/free map anyways and so we do not need atomic operation
> here.

OK, that makes sense then. Your latest patch looks good in that case.

-- 
dwmw2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/