Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754549AbYG3TWu (ORCPT ); Wed, 30 Jul 2008 15:22:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752888AbYG3TWl (ORCPT ); Wed, 30 Jul 2008 15:22:41 -0400 Received: from cdptpa-omtalb.mail.rr.com ([75.180.132.123]:38691 "EHLO cdptpa-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752322AbYG3TWk (ORCPT ); Wed, 30 Jul 2008 15:22:40 -0400 Date: Wed, 30 Jul 2008 15:22:38 -0400 Message-ID: <87hca7npmp.wl%ysato@users.sourceforge.jp> From: Yoshinori Sato To: Mike Frysinger , Andrew Morton Cc: lkml Subject: Re: [PATCH] blackfin / h8300 build error fix In-Reply-To: <8bd0f97a0807300911n4ae81b70v97276abf612f6b3e@mail.gmail.com> References: <87provuzwk.wl%ysato@users.sourceforge.jp> <8bd0f97a0807300911n4ae81b70v97276abf612f6b3e@mail.gmail.com> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.7 Emacs/22.2 (x86_64-pc-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3327 Lines: 101 At Wed, 30 Jul 2008 12:11:37 -0400, Mike Frysinger wrote: > > On Wed, Jul 30, 2008 at 11:58 AM, Yoshinori Sato wrote: > > init/main.c:781: undefined reference to `___early_initcall_end' > > > > Signed-off-by: Yoshinori Sato > > > > --- > > include/asm-generic/vmlinux.lds.h | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h > > index 6d88a92..07b2784 100644 > > --- a/include/asm-generic/vmlinux.lds.h > > +++ b/include/asm-generic/vmlinux.lds.h > > @@ -362,7 +362,7 @@ > > > > #define INITCALLS \ > > *(.initcallearly.init) \ > > - __early_initcall_end = .; \ > > + VMLINUX_SYMBOL(__early_initcall_end) = .; \ > > *(.initcall0.init) \ > > *(.initcall0s.init) \ > > *(.initcall1.init) \ > > -- > > 1.5.6.3 > > nice catch, thanks ... looks like BUG_TABLE, TRACEDATA, and PERCPU are > also broken, but blackfin/etc... arent using those which is why we > havent noticed yet ... > -mike Thanks. I fixed same. Signed-off-by: Yoshinori Sato include/asm-generic/vmlinux.lds.h | 14 +++++++------- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h index 6d88a92..04cae96 100644 --- a/include/asm-generic/vmlinux.lds.h +++ b/include/asm-generic/vmlinux.lds.h @@ -333,9 +333,9 @@ #define BUG_TABLE \ . = ALIGN(8); \ __bug_table : AT(ADDR(__bug_table) - LOAD_OFFSET) { \ - __start___bug_table = .; \ + VMLINUX_SYMBOL(__start___bug_table) = .; \ *(__bug_table) \ - __stop___bug_table = .; \ + VMLINUX_SYMBOL(__stop___bug_table) = .; \ } #else #define BUG_TABLE @@ -345,9 +345,9 @@ #define TRACEDATA \ . = ALIGN(4); \ .tracedata : AT(ADDR(.tracedata) - LOAD_OFFSET) { \ - __tracedata_start = .; \ + VMLINUX_SYMBOL(__tracedata_start) = .; \ *(.tracedata) \ - __tracedata_end = .; \ + VMLINUX_SYMBOL(__tracedata_end) = .; \ } #else #define TRACEDATA @@ -362,7 +362,7 @@ #define INITCALLS \ *(.initcallearly.init) \ - __early_initcall_end = .; \ + VMLINUX_SYMBOL(__early_initcall_end) = .; \ *(.initcall0.init) \ *(.initcall0s.init) \ *(.initcall1.init) \ @@ -383,9 +383,9 @@ #define PERCPU(align) \ . = ALIGN(align); \ - __per_cpu_start = .; \ + VMLINUX_SYMBOL(__per_cpu_start) = .; \ .data.percpu : AT(ADDR(.data.percpu) - LOAD_OFFSET) { \ *(.data.percpu) \ *(.data.percpu.shared_aligned) \ } \ - __per_cpu_end = .; + VMLINUX_SYMBOL(__per_cpu_end) = .; -- 1.5.6.3 -- Yoshinori Sato -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/