Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757571AbYG3Tu5 (ORCPT ); Wed, 30 Jul 2008 15:50:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756860AbYG3Tub (ORCPT ); Wed, 30 Jul 2008 15:50:31 -0400 Received: from mx1.suse.de ([195.135.220.2]:45274 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753177AbYG3Tu2 (ORCPT ); Wed, 30 Jul 2008 15:50:28 -0400 Date: Wed, 30 Jul 2008 12:39:42 -0700 From: Greg KH To: Martin Schwidefsky Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, lf_kernel_messages@lists.linux-foundation.org, Andrew Morton , Michael Holzheu , Gerrit Huizenga , Randy Dunlap , Jan Kara , Pavel Machek , Sam Ravnborg , Joe Perches , Jochen =?iso-8859-1?B?Vm/f?= , Kunai Takashi , Tim Bird Subject: Re: [patch 1/3] kmsg: Kernel message catalog macros. Message-ID: <20080730193942.GA22441@suse.de> References: <20080730165656.118280544@de.ibm.com> <20080730171156.824640459@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080730171156.824640459@de.ibm.com> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2472 Lines: 69 On Wed, Jul 30, 2008 at 06:56:57PM +0200, Martin Schwidefsky wrote: > From: Michael Holzheu > From: Martin Schwidefsky > > Introduce a new family of printk macros which prefixes each kmsg message > with a component name and allows to tag the printk with a message id. > > The kmsg component name is defined per source file with the KMSG_COMPONENT > macro. The first argument of each kmsg printk is the message id. The > message id "0" is special as it will suppress the message id prefix. > > If the message id will be printed to the console / syslog at all depends > on CONFIG_MSG_IDS. If it is "n" then a kmsg_xxx call is just another > printk wrapper. These macros are intended to be used uniformly in the > s390 architecture and the s390 device drivers. > > Signed-off-by: Michael Holzheu > Signed-off-by: Martin Schwidefsky > --- > > arch/s390/Kconfig | 9 +++ > include/linux/kmsg.h | 124 +++++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 133 insertions(+) > > Index: linux-2.6/arch/s390/Kconfig > =================================================================== > --- linux-2.6.orig/arch/s390/Kconfig > +++ linux-2.6/arch/s390/Kconfig > @@ -568,6 +568,15 @@ bool "s390 guest support (EXPERIMENTAL)" > select VIRTIO_CONSOLE > help > Select this option if you want to run the kernel under s390 linux > + > +config KMSG_IDS > + bool "Kernel message numbers" > + default y > + help > + Select this option if you want to include a message number to the > + prefix for kernel messages issued by the s390 architecture and > + driver code. See "Documentation/s390/kmsg.txt" for more details. > + > endmenu > > source "net/Kconfig" > Index: linux-2.6/include/linux/kmsg.h > =================================================================== > --- /dev/null > +++ linux-2.6/include/linux/kmsg.h > @@ -0,0 +1,124 @@ > +#ifndef _LINUX_KMSG_H > +#define _LINUX_KMSG_H > + > +#ifndef __KMSG_CHECKER > +#define __KMSG_CHECK(level, id) KERN_##level > +#endif What if __KMSG_CHECKER is enabled? What does __KMSG_CHECK resolve to then? And what sets __KMSG_CHECKER? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/