Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755671AbYG3URV (ORCPT ); Wed, 30 Jul 2008 16:17:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752798AbYG3URJ (ORCPT ); Wed, 30 Jul 2008 16:17:09 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:35690 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751808AbYG3URI (ORCPT ); Wed, 30 Jul 2008 16:17:08 -0400 Date: Wed, 30 Jul 2008 13:13:48 -0700 (PDT) From: Linus Torvalds To: Miklos Szeredi cc: jens.axboe@oracle.com, akpm@linux-foundation.org, nickpiggin@yahoo.com.au, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [patch v3] splice: fix race with page invalidation In-Reply-To: Message-ID: References: <20080730175406.GN20055@kernel.dk> <20080730194516.GO20055@kernel.dk> User-Agent: Alpine 1.10 (LFD 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1298 Lines: 35 On Wed, 30 Jul 2008, Miklos Szeredi wrote: > > Take this patch as a bugfix. It's not in any way showing the way > forward: as soon as you have the time, you can revert it and start > from the current state. > > Hmm? I dislike that mentality. The fact is, it's not a bug-fix, it's just papering over the real problem. And by papering it over, it then just makes people less likely to bother with the real issue. For example, and I talked about this earlier - what make syou think that the FUSE/NFSD behaviour you don't like is at all valid in the first place? If you depend on data not being truncated because you have it "in flight", tjhere's already something wrong there. It's _not_ just that people can see zero bytes in the reply - apparently they can see the file shrink before they see the read return. That kind of thing just worries me. And it might be a general NFS issue, not necessarily a FUSE one. So I think your whole approach stinks. I don't agree with the "bug-fix". It really smells like a "bug-paper-over". Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/