Date: Wed, 30 Jul 2008 23:51:30 +0100
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Eugeniy Meshcheryakov <eugen@debian.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] try harder to load tty ldisc driver
Message-ID: <20080730235130.32d36046@lxorguk.ukuu.org.uk>
In-Reply-To: <20080729204512.GA6242@localhost.localdomain>
References: <20080729204512.GA6242@localhost.localdomain>
Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street,
 Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a
 Lloegr o'r rhif cofrestru 3798903
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1025
Lines: 25

On Tue, 29 Jul 2008 22:45:12 +0200
Eugeniy Meshcheryakov <eugen@debian.org> wrote:

> Currently function tty_ldisc_get() tries to load an ldisc driver module
> only when tty_ldisc_try_get() returns -EAGAIN. This happens only if
> module is being unloaded. If ldisc module is not loaded
> tty_ldisc_try_get() returns -EINVAL and this case is not handled in
> tty_ldisc_get(), so request_module() is not called.
> 
> Attached patch fixes this by calling request_module() if
> tty_ldisc_try_get() returned any error code.
> 
> I discovered this when my UMTS modem stopped working with 2.6.27-rc1
> because module ppp_async was not loaded.
> 
> Signed-off-by: Eugeniy Meshcheryakov <eugen@debian.org>

Signed-off-by: Alan Cox <alan@redhat.com>

(And forwarded to the stable tree too)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/