Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759383AbYGaB0Z (ORCPT ); Wed, 30 Jul 2008 21:26:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753024AbYGaB0H (ORCPT ); Wed, 30 Jul 2008 21:26:07 -0400 Received: from stargate.chelsio.com ([12.22.49.110]:12823 "EHLO stargate.chelsio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753511AbYGaB0F convert rfc822-to-8bit (ORCPT ); Wed, 30 Jul 2008 21:26:05 -0400 X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Subject: RE: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator Date: Wed, 30 Jul 2008 18:24:05 -0700 Message-ID: <8A71B368A89016469F72CD08050AD334032EC7F5@maui.asicdesigners.com> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator Thread-Index: Acjye20kvxPfeh/PSxuVQTjXQDVkYgALwLfQ References: <200807300019.m6U0JkdY012558@localhost.localdomain> <4890C287.60508@pobox.com> From: "Karen Xie" To: "Jeff Garzik" Cc: , , , , "Steve Wise" , , , , , "Divy Le Ray" , "Dimitrios Michailidis" , "Casey Leedom" , "linux-scsi" , "LKML" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1629 Lines: 42 >Comments: > >* SCSI drivers should be submitted via the linux-scsi@vger.kernel.org >mailing list. Will do that. Thanks. > >* The driver is clean and readable, well done > >* From a networking standpoint, our main concern becomes how this >interacts with the networking stack. In particular, I'm concerned based >on reading the source that this driver uses "TCP port stealing" rather >than using a totally separate MAC address (and IP). > >Stealing a TCP port on an IP/interface already assigned is a common >solution in this space, but also a flawed one. Precisely because the >kernel and applications are unaware of this "special, magic TCP port" >you open the potential for application problems that are very difficult >for an admin to diagnose based on observed behavior. The collisions between the host stack and iSCSI offload are unlikely because the iSCSI target server's port is unique (nailed down as 3260). If an offload card is plugged in, all iSCSI connections to a given target (i.e., destination/port) are offloaded. There is precedence for this approach such as RDMA/iWarp. > >So, additional information on your TCP port usage would be greatly >appreciated. Also, how does this interact with IPv6? Clearly it >interacts with IPv4... Currently, IPv6 connection request will not be honored, I will make sure the checking is added in the resubmission. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/